linux-kernel - Re: [PATCH] arch: vdso: remove if-conditionals of $(c-gettimeofday-y)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mhng-2a609a54-0d13-4fb3-9966-086357936773@palmerdabbelt-glaptop>
Date:   Tue, 24 Aug 2021 20:49:39 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     masahiroy@...nel.org
CC:     luto@...nel.org, tglx@...utronix.de, vincenzo.frascino@....com,
        linux-kernel@...r.kernel.org, masahiroy@...nel.org,
        will@...nel.org, tsbogend@...ha.franken.de, mpe@...erman.id.au,
        catalin.marinas@....com, benh@...nel.crashing.org,
        linux-mips@...r.kernel.org, paulus@...ba.org,
        linux-riscv@...ts.infradead.org, aou@...s.berkeley.edu,
        linuxppc-dev@...ts.ozlabs.org, linux@...linux.org.uk,
        linux-arm-kernel@...ts.infradead.org,
        Paul Walmsley <paul.walmsley@...ive.com>
Subject:     Re: [PATCH] arch: vdso: remove if-conditionals of $(c-gettimeofday-y)

On Fri, 30 Jul 2021 22:57:33 PDT (-0700), masahiroy@...nel.org wrote:
> arm, arm64, mips, powerpc always select GENERIC_GETTIMEOFDAY, hence
> $(gettimeofday-y) never becomes empty.
>
> riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y,
> but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that
> condition. So, you can always define CFLAGS_vgettimeofday.o
>
> Remove all the meaningless conditionals.
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
>
>  arch/riscv/kernel/vdso/Makefile     |  5 +----

Acked-by: Palmer Dabbelt <palmerdabbelt@...gle.com>