lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Aug 2021 11:55:45 +0800 From: DENG Qingfang <dqfext@...il.com> To: Vladimir Oltean <olteanv@...il.com> Cc: Sean Wang <sean.wang@...iatek.com>, Landen Chao <Landen.Chao@...iatek.com>, Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, Philipp Zabel <p.zabel@...gutronix.de>, Russell King <linux@...linux.org.uk>, "open list:MEDIATEK SWITCH DRIVER" <netdev@...r.kernel.org>, "moderated list:ARM/Mediatek SoC support" <linux-arm-kernel@...ts.infradead.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@...ts.infradead.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net-next] net: dsa: mt7530: manually set up VLAN ID 0 On Tue, Aug 24, 2021 at 08:37:14PM +0300, Vladimir Oltean wrote: > On Wed, Aug 25, 2021 at 01:32:37AM +0800, DENG Qingfang wrote: > > Okay. So the Fixes tag should be 6087175b7991, which initially adds the > > software fallback support for mt7530. > > Ok. Did the old code not need VLAN 0 for VLAN-unaware ports, or are you > saying that since the VLAN table lookup was bypassed completely in the > old code, 'no VLAN 0' was an inconsequential error? > > I think it's the latter. Just wanted to make sure. So that means, either > this Fixes: tag or the other, the patch still belongs to net-next. From > my side you shouldn't need to resend. You're right. The old code does not use VLAN table lookup for VLAN-unaware ports, and the current code set VLAN-unaware ports to fallback mode so missing VLAN 0 will only make them fallback to SVL. > > Reviewed-by: Vladimir Oltean <olteanv@...il.com>
Powered by blists - more mailing lists