linux-kernel - Re: [PATCH] fs/ntfs3: Use kernel ALIGN macros over driver specific

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210825043715.GP7722@kadam>
Date:   Wed, 25 Aug 2021 07:37:15 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Kari Argillander <kari.argillander@...il.com>
Cc:     Konstantin Komarov <almaz.alexandrovich@...agon-software.com>,
        ntfs3@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/ntfs3: Use kernel ALIGN macros over driver specific

On Tue, Aug 24, 2021 at 09:20:59PM +0300, Kari Argillander wrote:
> Prefer built in ALIGN macros over special made ones. This can be
> helpful for some static analyzing tools.
> 

The patch is fine but the commit message is not clear that this fixes
a runtime bug.

The static checkers (Smatch) were complaining because QuadAlign() was
buggy.  If you try to align something higher than UINT_MAX it got
truncated to a u32.

regards,
dan carpenter