linux-kernel - Re: [PATCH] net: usb: asix: ax88772: fix boolconv.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210825183612.GD14337@pengutronix.de>
Date:   Wed, 25 Aug 2021 20:36:12 +0200
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     kernel test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        Linux Memory Management List <linux-mm@...ck.org>,
        Andrew Lunn <andrew@...n.ch>,
        Colin Ian King <colin.king@...onical.com>,
        Grant Grundler <grundler@...omium.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Oliver Neukum <oneukum@...e.com>, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: usb: asix: ax88772: fix boolconv.cocci warnings

On Wed, Aug 25, 2021 at 07:29:42AM -0700, Jakub Kicinski wrote:
> On Wed, 25 Aug 2021 06:22:07 +0200 Oleksij Rempel wrote:
> > On Wed, Aug 25, 2021 at 06:17:16AM +0800, kernel test robot wrote:
> > > From: kernel test robot <lkp@...el.com>
> > > 
> > > drivers/net/usb/asix_devices.c:757:60-65: WARNING: conversion to bool not needed here
> > > 
> > >  Remove unneeded conversion to bool
> > > 
> > > Semantic patch information:
> > >  Relational and logical operators evaluate to bool,
> > >  explicit conversion is overly verbose and unneeded.
> > > 
> > > Generated by: scripts/coccinelle/misc/boolconv.cocci
> > > 
> > > Fixes: 7a141e64cf14 ("net: usb: asix: ax88772: move embedded PHY detection as early as possible")
> > > CC: Oleksij Rempel <o.rempel@...gutronix.de>
> > > Reported-by: kernel test robot <lkp@...el.com>
> > > Signed-off-by: kernel test robot <lkp@...el.com>  
> > 
> > Reviewed-by: Oleksij Rempel <o.rempel@...gutronix.de>
> 
> This patch never made it into patchwork, would you mind resending it,
> Oleksij?

ack. done.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |