linux-kernel - Re: [PATCH] cpufreq: qcom-cpufreq-hw: Fix 'make allmodconfig' build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210825044130.14795-1-sj38.park@gmail.com>
Date:   Wed, 25 Aug 2021 06:41:30 +0200
From:   SeongJae Park <sj38.park@...il.com>
To:     Valdis Klētnieks <valdis.kletnieks@...edu>
Cc:     SeongJae Park <sj38.park@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Thara Gopinath <thara.gopinath@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sudeep Holla <sudeep.holla@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: qcom-cpufreq-hw: Fix 'make allmodconfig' build

From: SeongJae Park <sjpark@...zon.de>

On Tue, 24 Aug 2021 22:16:04 -0400 "Valdis Klētnieks" <valdis.kletnieks@...edu> wrote:

> On Tue, 24 Aug 2021 09:14:30 -0000, SeongJae Park said:
> 
> > > > ERROR: modpost: "cpu_scale" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined!
> > >
> > > That's a different patch, am working on fixing that one now..
> >
> > I didn't take a deep look here, so I unsure if this is an appropriate fix, but
> > I was able to work-around this issue for my use case with below change.
> >
> 
> >  DEFINE_PER_CPU(unsigned long, cpu_scale) = SCHED_CAPACITY_SCALE;
> > +EXPORT_PER_CPU_SYMBOL_GPL(cpu_scale);
> 
> Aha.  That's the part I wasn't finding.  Would you like to submit your patch,
> or shall I send it in with a "Suggested-by" for you?

I'd prefer 'Suggested-by', as I didn't take a deep look here.

Suggested-by: SeongJae Park <sjpark@...zon.de>


Thanks,
SJ