| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202108260347.QrfueUx8-lkp@intel.com>
Date: Thu, 26 Aug 2021 03:42:55 +0800
From: kernel test robot <lkp@...el.com>
To: Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: clang-built-linux@...glegroups.com, kbuild-all@...ts.01.org,
linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: drivers/staging/media/atomisp/pci/sh_css_params.c:2975:7: warning:
variable 'succ' set but not used
Hi Mauro,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 6e764bcd1cf72a2846c0e53d3975a09b242c04c9
commit: 5b552b198c2557295becd471bff53bb520fefee5 media: atomisp: re-enable warnings again
date: 1 year, 2 months ago
config: x86_64-randconfig-r003-20210825 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d26000e4cc2bc65e207a84fa26cb6e374d60aa12)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5b552b198c2557295becd471bff53bb520fefee5
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 5b552b198c2557295becd471bff53bb520fefee5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
drivers/staging/media/atomisp/pci/sh_css_params.c:1637:36: warning: variable 'row_padding' set but not used [-Wunused-but-set-variable]
unsigned int i, j, aligned_width, row_padding;
^
>> drivers/staging/media/atomisp/pci/sh_css_params.c:2975:7: warning: variable 'succ' set but not used [-Wunused-but-set-variable]
bool succ = true;
^
2 warnings generated.
--
>> drivers/staging/media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:34:6: warning: no previous prototype for function 'ia_css_isys_ibuf_rmgr_init' [-Wmissing-prototypes]
void ia_css_isys_ibuf_rmgr_init(void)
^
drivers/staging/media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:34:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void ia_css_isys_ibuf_rmgr_init(void)
^
static
>> drivers/staging/media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:40:6: warning: no previous prototype for function 'ia_css_isys_ibuf_rmgr_uninit' [-Wmissing-prototypes]
void ia_css_isys_ibuf_rmgr_uninit(void)
^
drivers/staging/media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:40:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void ia_css_isys_ibuf_rmgr_uninit(void)
^
static
>> drivers/staging/media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:46:6: warning: no previous prototype for function 'ia_css_isys_ibuf_rmgr_acquire' [-Wmissing-prototypes]
bool ia_css_isys_ibuf_rmgr_acquire(
^
drivers/staging/media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:46:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
bool ia_css_isys_ibuf_rmgr_acquire(
^
static
>> drivers/staging/media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:106:6: warning: no previous prototype for function 'ia_css_isys_ibuf_rmgr_release' [-Wmissing-prototypes]
void ia_css_isys_ibuf_rmgr_release(
^
drivers/staging/media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:106:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void ia_css_isys_ibuf_rmgr_release(
^
static
4 warnings generated.
vim +/succ +2975 drivers/staging/media/atomisp/pci/sh_css_params.c
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2971
41022d35ddf219 drivers/staging/media/atomisp/pci/sh_css_params.c Mauro Carvalho Chehab 2020-05-28 2972 static int
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2973 sh_css_create_isp_params(struct ia_css_stream *stream,
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2974 struct ia_css_isp_parameters **isp_params_out) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 @2975 bool succ = true;
bdfe0beb95eebc drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2976 unsigned int i;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2977 struct sh_css_ddr_address_map *ddr_ptrs;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2978 struct sh_css_ddr_address_map_size *ddr_ptrs_size;
41022d35ddf219 drivers/staging/media/atomisp/pci/sh_css_params.c Mauro Carvalho Chehab 2020-05-28 2979 int err = 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2980 size_t params_size;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2981 struct ia_css_isp_parameters *params =
9955d906f28098 drivers/staging/media/atomisp/pci/sh_css_params.c Mauro Carvalho Chehab 2020-05-27 2982 kvmalloc(sizeof(struct ia_css_isp_parameters), GFP_KERNEL);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2983
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2984 if (!params)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2985 {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2986 *isp_params_out = NULL;
41022d35ddf219 drivers/staging/media/atomisp/pci/sh_css_params.c Mauro Carvalho Chehab 2020-05-28 2987 err = -ENOMEM;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2988 IA_CSS_ERROR("%s:%d error: cannot allocate memory", __FILE__, __LINE__);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2989 IA_CSS_LEAVE_ERR_PRIVATE(err);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2990 return err;
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2991 } else
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2992 {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2993 memset(params, 0, sizeof(struct ia_css_isp_parameters));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2994 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2995
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2996 ddr_ptrs = ¶ms->ddr_ptrs;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2997 ddr_ptrs_size = ¶ms->ddr_ptrs_size;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2998
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 2999 for (i = 0; i < IA_CSS_PIPE_ID_NUM; i++)
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3000 {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3001 memset(¶ms->pipe_ddr_ptrs[i], 0,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3002 sizeof(params->pipe_ddr_ptrs[i]));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3003 memset(¶ms->pipe_ddr_ptrs_size[i], 0,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3004 sizeof(params->pipe_ddr_ptrs_size[i]));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3005 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3006
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3007 memset(ddr_ptrs, 0, sizeof(*ddr_ptrs));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3008 memset(ddr_ptrs_size, 0, sizeof(*ddr_ptrs_size));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3009
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3010 params_size = sizeof(params->uds);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3011 ddr_ptrs_size->isp_param = params_size;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3012 ddr_ptrs->isp_param =
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3013 ia_css_refcount_increment(IA_CSS_REFCOUNT_PARAM_BUFFER,
08fef4fa947ba7 drivers/staging/media/atomisp/pci/sh_css_params.c Mauro Carvalho Chehab 2020-05-26 3014 hmm_alloc(params_size, HMM_BO_PRIVATE, 0, NULL, 0));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3015 succ &= (ddr_ptrs->isp_param != mmgr_NULL);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3016
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3017 ddr_ptrs_size->macc_tbl = sizeof(struct ia_css_macc_table);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3018 ddr_ptrs->macc_tbl =
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3019 ia_css_refcount_increment(IA_CSS_REFCOUNT_PARAM_BUFFER,
08fef4fa947ba7 drivers/staging/media/atomisp/pci/sh_css_params.c Mauro Carvalho Chehab 2020-05-26 3020 hmm_alloc(sizeof(struct ia_css_macc_table), HMM_BO_PRIVATE, 0, NULL, 0));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3021 succ &= (ddr_ptrs->macc_tbl != mmgr_NULL);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3022
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3023 *isp_params_out = params;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3024 return err;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3025 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c Mauro Carvalho Chehab 2020-04-19 3026
:::::: The code at line 2975 was first introduced by commit
:::::: ad85094b293e40e7a2f831b0311a389d952ebd5e Revert "media: staging: atomisp: Remove driver"
:::::: TO: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (33058 bytes)
Powered by blists - more mailing lists