linux-kernel - Re: [PATCH v2 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mhng-8451ce80-2f44-40f0-945c-f2fd13a80bd7@palmerdabbelt-glaptop>
Date:   Tue, 24 Aug 2021 21:44:38 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     bmeng.cn@...il.com
CC:     Conor.Dooley@...rochip.com, Atish Patra <Atish.Patra@....com>,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        geert@...ux-m68k.org, bin.meng@...driver.com,
        conor.dooley@...rochip.com
Subject:     Re: [PATCH v2 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1

On Wed, 04 Aug 2021 05:30:14 PDT (-0700), bmeng.cn@...il.com wrote:
> From: Bin Meng <bin.meng@...driver.com>
>
> Per the DT spec, 'local-mac-address' is used to specify MAC address
> that was assigned to the network device, while 'mac-address' is used
> to specify the MAC address that was last used by the boot program,
> and shall be used only if the value differs from 'local-mac-address'
> property value.
>
> Signed-off-by: Bin Meng <bin.meng@...driver.com>
> Reviewed-by: conor dooley <conor.dooley@...rochip.com>
> ---
>
> (no changes since v1)
>
>  arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> index 0659068b62f7..a9c558366d61 100644
> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> @@ -317,7 +317,7 @@ emac1: ethernet@...12000 {
>  			reg = <0x0 0x20112000 0x0 0x2000>;
>  			interrupt-parent = <&plic>;
>  			interrupts = <70 71 72 73>;
> -			mac-address = [00 00 00 00 00 00];
> +			local-mac-address = [00 00 00 00 00 00];
>  			clocks = <&clkcfg 5>, <&clkcfg 2>;
>  			status = "disabled";
>  			clock-names = "pclk", "hclk";

Thanks, these are on fixes.