linux-kernel - RE: [PATCH v6 0/3] Visconti: Add Toshiba Visconti PCIe host controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <TYAPR01MB625257B58932922E355C988292C79@TYAPR01MB6252.jpnprd01.prod.outlook.com>
Date:   Thu, 26 Aug 2021 04:25:28 +0000
From:   <nobuhiro1.iwamatsu@...hiba.co.jp>
To:     <nobuhiro1.iwamatsu@...hiba.co.jp>, <bhelgaas@...gle.com>,
        <robh+dt@...nel.org>, <lorenzo.pieralisi@....com>
CC:     <linux-pci@...r.kernel.org>, <kw@...ux.com>, <kishon@...com>,
        <devicetree@...r.kernel.org>, <punit1.agrawal@...hiba.co.jp>,
        <yuji2.ishikawa@...hiba.co.jp>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v6 0/3] Visconti: Add Toshiba Visconti PCIe host
 controller driver

Hi,

Do you have any comments on this patch series?
If there is no problem, please apply it into the pci tree.

Best regards,
  Nobuhiro

> -----Original Message-----
> From: Nobuhiro Iwamatsu [mailto:nobuhiro1.iwamatsu@...hiba.co.jp]
> Sent: Wednesday, August 11, 2021 5:38 PM
> To: Bjorn Helgaas <bhelgaas@...gle.com>; Rob Herring <robh+dt@...nel.org>; Lorenzo Pieralisi
> <lorenzo.pieralisi@....com>
> Cc: linux-pci@...r.kernel.org; Krzysztof Wilczyński <kw@...ux.com>; Kishon Vijay Abraham I <kishon@...com>;
> devicetree@...r.kernel.org; agrawal punit(アグラワル プニト □ＳＷＣ◯ＡＣＴ) <punit1.agrawal@...hiba.co.jp>;
> ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開) <yuji2.ishikawa@...hiba.co.jp>;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> <nobuhiro1.iwamatsu@...hiba.co.jp>
> Subject: [PATCH v6 0/3] Visconti: Add Toshiba Visconti PCIe host controller driver
> 
> Hi,
> 
> This series is the PCIe driver for Toshiba's ARM SoC, Visconti[0].
> This provides DT binding documentation, device driver, MAINTAINER files.
> 
> Best regards,
>   Nobuhiro
> 
> [0]: https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image-recognition-processors-visconti.html
> 
>   dt-bindings: pci: Add DT binding for Toshiba Visconti PCIe controller
>     v5 -> v6:
>       - No update.
>     v4 -> v5:
>       - No update.
>     v3 -> v4:
>      - Changed the redundant clock name.
>     v2 -> v3:
>       - No update.
>     v1 -> v2:
>       - Remove white space.
>       - Drop num-viewport and bus-range from required.
>       - Drop status line from example.
>       - Drop bus-range from required.
>       - Removed lines defined in pci-bus.yaml from required.
> 
>   PCI: visconti: Add Toshiba Visconti PCIe host controller driver
>     v5 -> v6:
> - Remove unnecessary commit log.
> - Fix split line of visconti_add_pcie_port()
>     v4 -> v5:
>       - Remove PCIE_BUS_OFFSET
>       - Change link_up confirmation function of visconti_pcie_link_up().
>       - Move setting event mask before dw_pcie_link_up().
>       - Move the contents of visconti_pcie_power_on() to visconti_pcie_host_init().
>       - Remove code for link_gen.
>     v3 -> v4:
>       - Change variable from pci_addr to cpu_addr in visconti_pcie_cpu_addr_fixup().
>       - Change the calculation method of CPU addres from subtraction to mask, and
>         add comment.
>       - Drop dma_set_mask_and_coherent().
>       - Drop set MAX_MSI_IRQS.
>       - Drop dev_dbg for Link speed.
>       - Use use the dev_err_probe() to handle the devm_clk_get() failed.
>       - Changed the redundant clock name.
>     v2 -> v3:
>       - Update subject.
>       - Wrap description in 75 columns.
>       - Change config name to PCIE_VISCONTI_HOST.
>       - Update Kconfig text.
>       - Drop empty lines.
>       - Adjusted to 80 columns.
>       - Drop inline from functions for register access.
>       - Changed function name from visconti_pcie_check_link_status to
>         visconti_pcie_link_up.
>       - Update to using dw_pcie_host_init().
>       - Reorder these in the order of use in visconti_pcie_establish_link().
>       - Rewrite visconti_pcie_host_init() without dw_pcie_setup_rc().
>       - Change function name from  visconti_device_turnon() to
>         visconti_pcie_power_on().
>       - Unify formats such as dev_err().
>       - Drop error label in visconti_add_pcie_port().
>     v1 -> v2:
>       - Fix typo in commit message.
>       - Drop "depends on OF && HAS_IOMEM" from Kconfig.
>       - Stop using the pointer of struct dw_pcie.
>       - Use _relaxed variant.
>       - Drop dw_pcie_wait_for_link.
>       - Drop dbi resource processing.
>       - Drop MSI IRQ initialization processing.
> 
>   MAINTAINERS: Add entries for Toshiba Visconti PCIe controller
>     v5 -> v6:
>       - No update.
>     v4 -> v5:
>       - No update.
>     v3 -> v4:
>       - No update.
>     v2 -> v3:
>       - No update.
>     v1 -> v2:
>       - No update.
> 
> Nobuhiro Iwamatsu (3):
>   dt-bindings: pci: Add DT binding for Toshiba Visconti PCIe controller
>   PCI: visconti: Add Toshiba Visconti PCIe host controller driver
>   MAINTAINERS: Add entries for Toshiba Visconti PCIe controller
> 
>  .../bindings/pci/toshiba,visconti-pcie.yaml   | 110 ++++++
>  MAINTAINERS                                   |   2 +
>  drivers/pci/controller/dwc/Kconfig            |   9 +
>  drivers/pci/controller/dwc/Makefile           |   1 +
>  drivers/pci/controller/dwc/pcie-visconti.c    | 333 ++++++++++++++++++
>  5 files changed, 455 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml
>  create mode 100644 drivers/pci/controller/dwc/pcie-visconti.c
> 
> --
> 2.32.0