linux-kernel - Re: [PATCH 2/2] mm: don't allow executable ioremap mappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210826053719.GA17085@lst.de>
Date:   Thu, 26 Aug 2021 07:37:19 +0200
From:   Christoph Hellwig <hch@....de>
To:     Nicholas Piggin <npiggin@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 2/2] mm: don't allow executable ioremap mappings

On Thu, Aug 26, 2021 at 12:46:34PM +1000, Nicholas Piggin wrote:
> I can't see why this is a problem. powerpcs can but it seems like a bad 
> idea anyway.
> 
> Any point to a WARN_ON or return -EINVAL? Hmm, maybe that doesn't work 
> for archs that don't support NX. We could add a check for ones that do 
> support it though... But that's for another patch.

This is the same as we do for regular vmap.  I can't remember why we
decided on this particular approach, as it's been a while.