linux-kernel - Re: [PATCH v2] nvme-tcp: Do not reset transport on data digest errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210826080449.6pzvgihxzqbsosrx@carbon.lan>
Date:   Thu, 26 Aug 2021 10:04:49 +0200
From:   Daniel Wagner <dwagner@...e.de>
To:     Hannes Reinecke <hare@...e.de>
Cc:     linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Sagi Grimberg <sagi@...mberg.me>, yi.he@....com
Subject: Re: [PATCH v2] nvme-tcp: Do not reset transport on data digest errors

On Wed, Aug 25, 2021 at 05:27:10PM +0200, Hannes Reinecke wrote:
> > @@ -506,6 +514,7 @@ static int nvme_tcp_process_nvme_cqe(struct nvme_tcp_queue *queue,
> >   static int nvme_tcp_handle_c2h_data(struct nvme_tcp_queue *queue,
> >   		struct nvme_tcp_data_pdu *pdu)
> >   {
> > +	struct nvme_tcp_request *req;
> >   	struct request *rq;
> >   	rq = nvme_find_rq(nvme_tcp_tagset(queue), pdu->command_id);
> > @@ -534,6 +543,8 @@ static int nvme_tcp_handle_c2h_data(struct nvme_tcp_queue *queue,
> >   		return -EPROTO;
> >   	}
> > +	req = blk_mq_rq_to_pdu(rq);
> > +	req->status = NVME_SC_SUCCESS;
> >   	return 0;
> >   }
> 
> Can't you move the initialisation to nvme_tcp_setup_cmd_pdu()?
> That'll save to to have to reference the tcp request here ...

Yes, that's a why better place to initialize it. Let me spin a new
version.