linux-kernel - Re: [PATCH 1/6] staging: rtl8723bs: remove sdio_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YSdnDBH7Er7nLr+d@kroah.com>
Date:   Thu, 26 Aug 2021 12:03:56 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Bryan Brattlof <hello@...anbrattlof.com>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] staging: rtl8723bs: remove sdio_write_mem()

On Sat, Aug 21, 2021 at 11:55:05PM +0000, Bryan Brattlof wrote:
> The sdio_write_mem() function is unused in the driver. We can remove it.
> 

How do we know it is unused?

Please remove the pointer as well, at the same time, so that we can
obviously see that it is unused (or not).

Same for the other patches in this series.

Also, when you resend this, please use git send-email properly, so that
the patches are threaded so our tools can pick them up easier.  This
series was not threaded for some odd reason.

thanks,

greg k-h