linux-kernel - Re: [PATCH] staging: rtl8723bs: remove sdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YSdn6vLOo/WG/9rS@kroah.com>
Date:   Thu, 26 Aug 2021 12:07:38 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Bryan Brattlof <hello@...anbrattlof.com>
Cc:     linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: remove sdio_osintf.h

On Mon, Aug 23, 2021 at 10:12:21PM +0000, Bryan Brattlof wrote:
> All definitions inside sdio_osintf.h are unused. Remove it.
> 
> Signed-off-by: Bryan Brattlof <hello@...anbrattlof.com>
> ---
>  drivers/staging/rtl8723bs/include/drv_types.h   |  1 -
>  drivers/staging/rtl8723bs/include/sdio_osintf.h | 16 ----------------
>  2 files changed, 17 deletions(-)
>  delete mode 100644 drivers/staging/rtl8723bs/include/sdio_osintf.h
> 
> diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h
> index 580028d28c42..0e6741db95bf 100644
> --- a/drivers/staging/rtl8723bs/include/drv_types.h
> +++ b/drivers/staging/rtl8723bs/include/drv_types.h
> @@ -489,7 +489,6 @@ static inline u8 *myid(struct eeprom_priv *peepriv)
>  }
> 
>  /*  HCI Related header file */
> -#include <sdio_osintf.h>
>  #include <sdio_ops.h>
>  #include <sdio_hal.h>
> 
> diff --git a/drivers/staging/rtl8723bs/include/sdio_osintf.h b/drivers/staging/rtl8723bs/include/sdio_osintf.h
> deleted file mode 100644
> index 146b44f95e29..000000000000
> --- a/drivers/staging/rtl8723bs/include/sdio_osintf.h
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -/******************************************************************************
> - *
> - * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
> - *
> - ******************************************************************************/
> -#ifndef __SDIO_OSINTF_H__
> -#define __SDIO_OSINTF_H__
> -
> -
> -
> -u8 sd_hal_bus_init(struct adapter *padapter);
> -u8 sd_hal_bus_deinit(struct adapter *padapter);
> -void sd_c2h_hdl(struct adapter *padapter);

What about the instances in
drivers/staging/rtl8723bs/include/sdio_hal.h?  Please remove them at the
same time.

thanks,

greg k-h