linux-kernel - Re: [PATCH 2/3] drm/etnaviv: fix dma configuration of the virtual device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ebbb3cb0b07e45cc4171747fae844633@walle.cc>
Date:   Thu, 26 Aug 2021 14:17:35 +0200
From:   Michael Walle <michael@...le.cc>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
Cc:     etnaviv@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org,
        "Lukas F . Hartmann" <lukas@...re.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Christian Gmeiner <christian.gmeiner@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH 2/3] drm/etnaviv: fix dma configuration of the virtual
 device

Am 2021-08-26 14:14, schrieb Russell King (Oracle):
> On Thu, Aug 26, 2021 at 02:10:05PM +0200, Michael Walle wrote:
>> +	pdev->dev.coherent_dma_mask = DMA_BIT_MASK(40);
>> +	pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask;
> 
> Please use dma_coerce_mask_and_coherent() here instead.

It will be removed altogether in patch 3/3. I just moved the
current code around here. I could drop the code moving in 2/3. I
wasn't sure whats best.

-michael