linux-kernel - Re: [PATCH 1/2] Documentation: dmaengine: Add a description of what dmatest does

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YSeOpxIVJNCcKtEV@matsya>
Date:   Thu, 26 Aug 2021 18:22:55 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Daniel Thompson <daniel.thompson@...aro.org>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Jonathan Corbet <corbet@....net>,
        dmaengine <dmaengine@...r.kernel.org>,
        Linux Documentation List <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        patches@...aro.org, Haavard Skinnemoen <hskinnemoen@...el.com>,
        Håvard Skinnemoen <hskinnemoen@...il.com>
Subject: Re: [PATCH 1/2] Documentation: dmaengine: Add a description of what
 dmatest does

On 19-08-21, 10:13, Daniel Thompson wrote:
> On Wed, Aug 18, 2021 at 06:27:52PM +0300, Andy Shevchenko wrote:
> > On Wed, Aug 18, 2021 at 6:15 PM Daniel Thompson
> > <daniel.thompson@...aro.org> wrote:
> > >
> > > Currently it can difficult to determine what dmatest does without
> > > reading the source code. Let's add a description.
> > >
> > > The description is taken mostly from the patch header of
> > > commit 4a776f0aa922 ("dmatest: Simple DMA memcpy test client")
> > > although it has been edited and updated slightly.
> > 
> > > Signed-off-by: Haavard Skinnemoen <hskinnemoen@...el.com>
> > 
> > Not sure if you can use it like this (I mean the above SoB)
> 
> I wondered about that.
> 
> In the end I concluded that if I had picked up code from an old patch
> and edited to this degree then I would probably consider it a new
> patch but be clear about credit and preserve the original SoB. I saw no
> real reason to treat the contents of a patch header much different.
> 
> However, I'm very happy to make the credit more informal if needed.

It would be better if we be formal when giving credit. I am okay with
sob by Haavard if he acks it...
Daniel, Yes the intention is very noble, but I would have Haavard ack
before applying a patch with his sob, if not lets drop it and give
credit in changelog :)

-- 
~Vinod