linux-kernel - Re: [PATCH 1/3] drm/etnaviv: use PLATFORM_DEVID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH9NwWcFdt=C=aEp48462wXA6Q47CvTVoRQawyZMuPwwgVzzUA@mail.gmail.com>
Date:   Thu, 26 Aug 2021 14:59:57 +0200
From:   Christian Gmeiner <christian.gmeiner@...il.com>
To:     Michael Walle <michael@...le.cc>
Cc:     The etnaviv authors <etnaviv@...ts.freedesktop.org>,
        DRI mailing list <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "Lukas F . Hartmann" <lukas@...re.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Russell King <linux+etnaviv@...linux.org.uk>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH 1/3] drm/etnaviv: use PLATFORM_DEVID_NONE

Am Do., 26. Aug. 2021 um 14:10 Uhr schrieb Michael Walle <michael@...le.cc>:
>
> There is already a macro for the magic value. Use it.
>
> Signed-off-by: Michael Walle <michael@...le.cc>

Reviewed-by: Christian Gmeiner <christian.gmeiner@...il.com>

I will wait for v2 for the rest of the changes to review.

> ---
>  drivers/gpu/drm/etnaviv/etnaviv_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> index 7dcc6392792d..2509b3e85709 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> @@ -653,7 +653,7 @@ static int __init etnaviv_init(void)
>                 if (!of_device_is_available(np))
>                         continue;
>
> -               pdev = platform_device_alloc("etnaviv", -1);
> +               pdev = platform_device_alloc("etnaviv", PLATFORM_DEVID_NONE);
>                 if (!pdev) {
>                         ret = -ENOMEM;
>                         of_node_put(np);
> --
> 2.30.2
>


-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info/privacypolicy