linux-kernel - Re: [PATCH linux-next] powerpc/tm: remove duplicate include in tm-poison.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wno89t9m.fsf@mpe.ellerman.id.au>
Date:   Fri, 27 Aug 2021 00:26:29 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Christophe Leroy <christophe.leroy@...roup.eu>,
        Shuah Khan <skhan@...uxfoundation.org>, cgel.zte@...il.com
Cc:     yong.yiran@....com.cn, Zeal Robot <zealci@....com.cn>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        paulus@...ba.org, linux-kselftest@...r.kernel.org, shuah@...nel.org
Subject: Re: [PATCH linux-next] powerpc/tm: remove duplicate include in
 tm-poison.c

Christophe Leroy <christophe.leroy@...roup.eu> writes:
> Le 24/08/2021 à 16:40, Shuah Khan a écrit :
>> On 8/5/21 12:52 AM, cgel.zte@...il.com wrote:
>>> From: yong yiran <yong.yiran@....com.cn>
>>>
>>> 'inttypes.h' included in 'tm-poison.c' is duplicated.
>>> Remove all but the first include of inttypes.h from tm-poison.c.
>>>
>>> Reported-by: Zeal Robot <zealci@....com.cn>
>>> Signed-off-by: yong yiran <yong.yiran@....com.cn>
>>> ---
>>>   tools/testing/selftests/powerpc/tm/tm-poison.c | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c 
>>> b/tools/testing/selftests/powerpc/tm/tm-poison.c
>>> index 29e5f26af7b9..27c083a03d1f 100644
>>> --- a/tools/testing/selftests/powerpc/tm/tm-poison.c
>>> +++ b/tools/testing/selftests/powerpc/tm/tm-poison.c
>>> @@ -20,7 +20,6 @@
>>>   #include <sched.h>
>>>   #include <sys/types.h>
>>>   #include <signal.h>
>>> -#include <inttypes.h>
>>>   #include "tm.h"
>>>
>> 
>> We can't accept this patch. The from and Signed-off-by don't match.
>> 
>
> As far as I can see they match. You have:
>
> From: yong yiran <yong.yiran@....com.cn>
> Signed-off-by: yong yiran <yong.yiran@....com.cn>

Regardless I already have a patch queued to fix this, from a different
CI bot.

cheers