linux-kernel - Re: [PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Aug 2021 07:50:17 -0700
From:   Joe Perches <joe@...ches.com>
To:     Colin King <colin.king@...onical.com>,
        Raju Rangoju <rajur@...lsio.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't"

On Thu, 2021-08-26 at 13:01 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> There are spelling mistakes in dev_err and dev_info messages. Fix them.
[]
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
[]
> @@ -120,7 +120,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6)
>  				write_unlock_bh(&ctbl->lock);
>  1 file changed, 2 insertions(+), 2 deletions(-)
>  				dev_err(adap->pdev_dev,
>  					"CLIP FW cmd failed with error %d, "
> -					"Connections using %pI6c wont be "
> +					"Connections using %pI6c won't be "
>  					"offloaded",
>  					ret, ce->addr6.sin6_addr.s6_addr);
>  				return ret;
> @@ -133,7 +133,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6)
>  	} else {
>  		write_unlock_bh(&ctbl->lock);
>  		dev_info(adap->pdev_dev, "CLIP table overflow, "
> -			 "Connections using %pI6c wont be offloaded",
> +			 "Connections using %pI6c won't be offloaded",
>  			 (void *)lip);

This is an unnecessary cast.
And these could coalesce the format fragments and add newlines too.