linux-kernel - Re: [PATCH] bus: mhi: core: Update comments on mhi_prepare_for_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 26 Aug 2021 10:11:40 -0700
From:   Bhaumik Bhatt <bbhatt@...eaurora.org>
To:     Jeffrey Hugo <quic_jhugo@...cinc.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     mani@...nel.org, hemantk@...eaurora.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@...cinc.com>
Subject: Re: [PATCH] bus: mhi: core: Update comments on
 mhi_prepare_for_power_up

On 2021-08-26 09:32 AM, Jeffrey Hugo wrote:
> From: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@...cinc.com>
> 
> After "bus: mhi: core: Remove pre_init flag used for power purposes"
> mhi_prepare_for_power_up() is no longer an optional API. All users
> of MHI should call this API before power up sequence to initialize
> MHI context. Update the comments on this API to make this clear.
> 
> Fixes: eee87072e2fb ("bus: mhi: core: Remove pre_init flag used for
> power purposes")
> Signed-off-by: Pranjal Ramajor Asha Kanojiya 
> <quic_pkanojiy@...cinc.com>
> Signed-off-by: Jeffrey Hugo <quic_jhugo@...cinc.com>
> ---
>  include/linux/mhi.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 56e7934..483b852 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -617,10 +617,8 @@ int mhi_get_free_desc_count(struct mhi_device 
> *mhi_dev,
> 
>  /**
>   * mhi_prepare_for_power_up - Do pre-initialization before power up.
> - *                            This is optional, call this before power 
> up if
> - *                            the controller does not want bus 
> framework to
> - *                            automatically free any allocated memory 
> during
> - *                            shutdown process.
> + *                            Call this before MHI power up sequence 
> to
> + *                            initialize MHI context.
>   * @mhi_cntrl: MHI controller
>   */
>  int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl);

Thanks for catching this!

Reviewed-by: Bhaumik Bhatt <bbhatt@...eaurora.org>

Adding Mani's Linaro email ID for pick-up.

Thanks,
Bhaumik
---
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,
a Linux Foundation Collaborative Project