linux-kernel - [PATCH] ATA:libata-pmp: fix warn: missing error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210826174301.21255-1-asha.16@itfac.mrt.ac.lk>
Date:   Thu, 26 Aug 2021 23:13:01 +0530
From:   "F.A.Sulaiman" <asha.16@...ac.mrt.ac.lk>
To:     axboe@...nel.dk
Cc:     "F.A.Sulaiman" <asha.16@...ac.mrt.ac.lk>,
        linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] ATA:libata-pmp: fix warn: missing error code

smatch reported 'sata_pmp_eh_recover() warn: missing error code 'rc''.
This patch resolve it by adding I/O error code to 'rc'.

Signed-off-by: F.A. SULAIMAN <asha.16@...ac.mrt.ac.lk>
---
 drivers/ata/libata-pmp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c
index ba7be3f38617..2ea7b9986f4e 100644
--- a/drivers/ata/libata-pmp.c
+++ b/drivers/ata/libata-pmp.c
@@ -977,6 +977,7 @@ static int sata_pmp_eh_recover(struct ata_port *ap)
 			ata_link_warn(pmp_link,
 				"failed to disable NOTIFY (err_mask=0x%x)\n",
 				err_mask);
+			rc = -EIO;
 			goto pmp_fail;
 		}
 	}
-- 
2.17.1