linux-kernel - Re: [PATCH 0/3] ASoC: wcd9335: Firx some resources leak in the probe and remove function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <163000225499.699341.15649110189101404680.b4-ty@kernel.org>
Date:   Thu, 26 Aug 2021 19:30:25 +0100
From:   Mark Brown <broonie@...nel.org>
To:     bgoswami@...eaurora.org, perex@...ex.cz,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        srinivas.kandagatla@...aro.org, tiwai@...e.com, vkoul@...nel.org,
        lgirdwood@...il.com
Cc:     Mark@...ena.org.uk, Brown@...ena.org.uk, broonie@...nel.org,
        alsa-devel@...a-project.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] ASoC: wcd9335: Firx some resources leak in the probe and remove function

From: Mark Brown,,, <broonie@...nel.org>

On Mon, 16 Aug 2021 07:25:01 +0200, Christophe JAILLET wrote:
> The first 2 patches are sraightforward and look logical to me.
> 
> However, the 3rd one in purely speculative. It is based on the fact that a
> comment states that we enable some irqs on some slave ports. That said, it writes
> 0xFF in some registers.
> 
> So, I guess that we should disable these irqs when the driver is removed. That
> said, writing 0x00 at the same place looks logical to me.
> 
> [...]

Applied, thanks!

[1/3] ASoC: wcd9335: Fix a double irq free in the remove function
      commit: 7a6a723e98aa45f393e6add18f7309dfffa1b0e2
[2/3] ASoC: wcd9335: Fix a memory leak in the error handling path of the probe function
      commit: fc6fc81caa63900cef9ebb8b2e365c3ed5a9effb
[3/3] ASoC: wcd9335: Disable irq on slave ports in the remove function
      commit: d3efd26af2e044ff2b48d38bb871630282d77e60

Best regards,
-- 
Mark Brown,,, <broonie@...nel.org>