linux-kernel - Re: [PATCH v3 1/2] staging: r8188eu: Use usb_control_msg_recv/send() in usbctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b5507e5b-d396-f442-591e-994e2b929397@gmail.com>
Date:   Thu, 26 Aug 2021 22:12:35 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH v3 1/2] staging: r8188eu: Use usb_control_msg_recv/send()
 in usbctrl_vendorreq()

On 8/26/21 9:56 PM, Fabio M. De Francesco wrote:
> On Thursday, August 26, 2021 8:18:23 PM CEST Pavel Skripkin wrote:
>> On 8/25/21 6:53 AM, Fabio M. De Francesco wrote:
>> > Replace usb_control_msg() with the new usb_control_msg_recv() and
>> > usb_control_msg_send() API of USB Core in usbctrl_vendorreq().
>> > Remove no more needed variables. Move out of an if-else block
>> > some code that it is no more dependent on status < 0. Remove
>> > redundant code depending on status > 0 or status == len.
>> > 
>> > Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@...il.com>
>> > ---
>> 
>> FYI, I've tested this patch with TP-Link TL-WN722N v3 + qemu :)
>> 
>> 
>> Tested-by: Pavel Skripkin <paskripkin@...il.com>
>> 
>> 
>> NOTE: I am still not able to apply 2/2, so tested tag is only for 1/2
>> 
>> 
>> With regards,
>> Pavel Skripkin
> 
> Dear Pavel,
> 
> Thanks for testing. It was very kind from you.I'll add this to the Reviewed-tag
> that you had already given to my patch.
> 
> However, I intend to rebase and resend this 1/2 and the 2/2 of this series, because
> (as we already found) they logically follow another patch of mine that is still in the
> queue ("staging: r8188eu: Remove _enter/_exit_critical_mutex()").
> 
> The patch above has already been reviewed by Greg and he found that it looks
> good, but he cannot apply it because it is not tested (for the reasons I've already
> explained with a couple of messages)
> 
> Unfortunately, until "Remove _enter/_exit_critical_mutex()" is not tested, Greg
> won't apply it and the 2/2 of this series cannot be applied too.
> 
> Please, if you have time, do you mind to test also that? It would allow me to resend
> it with your "Tested-by" tag and Greg will surely apply it. No worries if you have no
> time for doing this test, otherwise you may find it at:
> 
> https://lore.kernel.org/lkml/20210819221241.31987-1-fmdefrancesco@gmail.com/
> 
> Please, if you are interested, read the whole thread. You'll see that Greg would apply
> it, only if tested.
> 
> Thanks very much for your help and kindness,
> 


Hi, Fabio!


Ok, I will test it until yesterday evening. I want to enable some debug 
options and sanitizers and recompile the kernel :)

Today I will try to automate testing by writing scripts for connect, 
disconnect and other scenarios. I guess, it will help to test various 
corner cases


Simple test actually passed: I've connected to wifi + pinged google, but 
mutexes can cause deadlock and other not cool bugs, so I will try to 
enable as many sanitizers as possible and retest it :)




With regards,
Pavel Skripkin