linux-kernel - Re: [PATCH] ASoC: dwc: Get IRQ optionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VejabzoA8xBYFH1X-9vwS4U8SsivnS4be+H7vUTGH8fKQ@mail.gmail.com>
Date:   Fri, 27 Aug 2021 11:08:38 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Robin Murphy <robin.murphy@....com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: dwc: Get IRQ optionally

On Wed, Aug 25, 2021 at 7:04 PM Robin Murphy <robin.murphy@....com> wrote:
>
> The IRQ is explicitly optional, so use platform_get_irq_optional() and
> avoid platform_get_irq() logging a spurious error when trying to use the
> thing in DMA mode.

...

> -       irq = platform_get_irq(pdev, 0);
> +       irq = platform_get_irq_optional(pdev, 0);

>         if (irq >= 0) {

It has to be changed to if (irq > 0).
But since it's already applied, I think it will be another patch.

>                 ret = devm_request_irq(&pdev->dev, irq, i2s_irq_handler, 0,
>                                 pdev->name, dev);

-- 
With Best Regards,
Andy Shevchenko