linux-kernel - Re: [PATCH v2] net: don't unconditionally copy_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <163005420640.11012.15053925482191718453.git-patchwork-notify@kernel.org>
Date:   Fri, 27 Aug 2021 08:50:06 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Peter Collingbourne <pcc@...gle.com>
Cc:     davem@...emloft.net, kuba@...nel.org, colin.king@...onical.com,
        cong.wang@...edance.com, viro@...iv.linux.org.uk,
        gregkh@...uxfoundation.org, David.Laight@...lab.com,
        arnd@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] net: don't unconditionally copy_from_user a struct ifreq
 for socket ioctls

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Thu, 26 Aug 2021 12:46:01 -0700 you wrote:
> A common implementation of isatty(3) involves calling a ioctl passing
> a dummy struct argument and checking whether the syscall failed --
> bionic and glibc use TCGETS (passing a struct termios), and musl uses
> TIOCGWINSZ (passing a struct winsize). If the FD is a socket, we will
> copy sizeof(struct ifreq) bytes of data from the argument and return
> -EFAULT if that fails. The result is that the isatty implementations
> may return a non-POSIX-compliant value in errno in the case where part
> of the dummy struct argument is inaccessible, as both struct termios
> and struct winsize are smaller than struct ifreq (at least on arm64).
> 
> [...]

Here is the summary with links:
  - [v2] net: don't unconditionally copy_from_user a struct ifreq for socket ioctls
    https://git.kernel.org/netdev/net/c/d0efb16294d1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html