linux-kernel - Re: [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69835666-1710-5103-fb06-2636a3a3c5bb@fujitsu.com>
Date:   Fri, 27 Aug 2021 01:35:34 +0000
From:   "lizhijian@...itsu.com" <lizhijian@...itsu.com>
To:     Shuah Khan <skhan@...uxfoundation.org>,
        "lizhijian@...itsu.com" <lizhijian@...itsu.com>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
CC:     "philip.li@...el.com" <philip.li@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC



On 27/08/2021 05:10, Shuah Khan wrote:
> On 8/25/21 7:58 PM, Li Zhijian wrote:
>> SYNC was removed since aff9da10e21 ("staging/android: make sync_timeline internal to sw_sync")
>> LKP/0Day will check if all configs listing under selftests are able to be enabled properly.
>>
>
> Can you please state what you arr fxing and also keep the sentences
> 75 chars or less.
>
> Where is LKP warning? 
https://01.org/lkp
LKP(aka. 0Day) often reports issue related to the *recent* kernel commits/WIP patches publicly.
As the LKP keeping improvement, it will cover more aspects in the kernel so that more issues will be detected.

So in this case, which is related to too old kernel, it just reported it internally.


> Include the warning and explain why this
> change is necessary.
- it's not reasonable to keep the deprecated configs, right ?

- In my understanding, configs under kselftests are recommended by corresponding tests.
So if some configs are missing, it will impact the testing results

Do you mean the commit log should include above 2 reasons ?

Thanks

>
>> For the missing configs, it will report something like:
>> LKP WARN miss config CONFIG_SYNC= of sync/config
>>
>> CC: Philip Li <philip.li@...el.com>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Signed-off-by: Li Zhijian <lizhijian@...fujitsu.com>
>> ---
>
> thanks,
> -- Shuah
>
>