linux-kernel - Re: [Linux-cachefs] [PATCH v2 04/12] fscache: Add a cookie debug ID and use that in traces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAB9dFdufkVyqS4NadbqVrtjmciLvpuAZOU8woWWcURcnuaZ=GA@mail.gmail.com>
Date:   Fri, 27 Aug 2021 09:49:35 -0300
From:   Marc Dionne <marc.dionne@...istor.com>
To:     David Howells <dhowells@...hat.com>
Cc:     linux-cachefs@...hat.com, Steve French <sfrench@...ba.org>,
        linux-nfs@...r.kernel.org, linux-afs@...ts.infradead.org,
        linux-cifs@...r.kernel.org,
        Dominique Martinet <asmadeus@...ewreck.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Anna Schumaker <anna.schumaker@...app.com>,
        linux-fsdevel@...r.kernel.org,
        v9fs-developer@...ts.sourceforge.net, ceph-devel@...r.kernel.org
Subject: Re: [Linux-cachefs] [PATCH v2 04/12] fscache: Add a cookie debug ID
 and use that in traces

On Fri, Aug 27, 2021 at 9:31 AM David Howells <dhowells@...hat.com> wrote:
>
>
> Add a cookie debug ID and use that in traces and in procfiles rather than
> displaying the (hashed) pointer to the cookie.  This is easier to correlate
> and we don't lose anything when interpreting oops output since that shows
> unhashed addresses and registers that aren't comparable to the hashed
> values.
>
> Changes:
>
> ver #2:
>  - Fix the fscache_op tracepoint to handle a NULL cookie pointer.
>
> Signed-off-by: David Howells <dhowells@...hat.com>
> Reviewed-by: Jeff Layton <jlayton@...hat.com>
> cc: linux-cachefs@...hat.com
> Link: https://lore.kernel.org/r/158861210988.340223.11688464116498247790.stgit@warthog.procyon.org.uk/ # rfc
> Link: https://lore.kernel.org/r/159465769844.1376105.14119502774019865432.stgit@warthog.procyon.org.uk/
> Link: https://lore.kernel.org/r/160588459097.3465195.1273313637721852165.stgit@warthog.procyon.org.uk/ # rfc
> Link: https://lore.kernel.org/r/162431193544.2908479.17556704572948300790.stgit@warthog.procyon.org.uk/

Reviewed-by: Marc Dionne <marc.dionne@...istor.com>

Marc