linux-kernel - Re: [PATCH net-next v2 1/2] net: pcs: xpcs: enable skip xPCS soft reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YShGqldtThS2z0eI@lunn.ch>
Date:   Fri, 27 Aug 2021 03:58:02 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Wong Vee Khee <vee.khee.wong@...ux.intel.com>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Vladimir Oltean <vladimir.oltean@....com>,
        Voon Weifeng <weifeng.voon@...el.com>,
        Michael Sit Wei Hong <michael.wei.hong.sit@...el.com>
Subject: Re: [PATCH net-next v2 1/2] net: pcs: xpcs: enable skip xPCS soft
 reset

On Fri, Aug 27, 2021 at 07:51:33AM +0800, Wong Vee Khee wrote:
> Unlike any other platforms, Intel AlderLake-S uses Synopsys SerDes where
> all the SerDes PLL configurations are controlled by the xPCS at the BIOS
> level. If the driver perform a xPCS soft reset on initialization, these
> settings will be switched back to the power on reset values.
> 
> This patch introduced a new xpcs_reset() function for drivers such as
> sja1105 and stmmac to decide whether or not to perform a xPCS soft
> reset.
> 
> +	/* If Device ID are all ones, there is no device found */
> +	if (xpcs_id == 0xffffffff)
> +		goto out;
> +

This does not look like plain refactoring. It is not code moved from
somewhere else. At minimum, it needs explaining in the commit message,
but it probably should be a commit of its own.

    Andrew