[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YShJv2XRud7pSseZ@lunn.ch>
Date: Fri, 27 Aug 2021 04:11:11 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Joel Stanley <joel@....id.au>
Cc: "Gabriel L. Somlo" <gsomlo@...il.com>,
Florent Kermarrec <florent@...oy-digital.fr>,
"David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Karol Gugala <kgugala@...micro.com>,
Mateusz Holenko <mholenko@...micro.com>,
devicetree <devicetree@...r.kernel.org>,
Networking <netdev@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
David Shah <dave@....me>, Stafford Horne <shorne@...il.com>
Subject: Re: [PATCH v2 2/2] net: Add driver for LiteX's LiteEth network
interface
On Wed, Aug 25, 2021 at 06:35:17AM +0000, Joel Stanley wrote:
> On Tue, 24 Aug 2021 at 19:43, Gabriel L. Somlo <gsomlo@...il.com> wrote:
> >
> > Hi Joel,
> >
> > Couple of comments below:
> >
> > On Fri, Aug 20, 2021 at 05:17:26PM +0930, Joel Stanley wrote:
>
> > > diff --git a/drivers/net/ethernet/litex/Kconfig b/drivers/net/ethernet/litex/Kconfig
> > > new file mode 100644
> > > index 000000000000..265dba414b41
> > > --- /dev/null
> > > +++ b/drivers/net/ethernet/litex/Kconfig
>
> > > +
> > > +config LITEX_LITEETH
> > > + tristate "LiteX Ethernet support"
> >
> > Mostly cosmetic, but should there be a "depends on LITEX" statement in here?
>
> No, there's as there is no dependency on the litex soc driver.
Which is good, you will get more build coverage that way, it will be
built of x86, arm, mips, etc...
>
> > Maybe also "select MII" and "select PHYLIB"?
>
> Again, there is no mii or phy code so the driver doesn't need these.
Yet.
At some point i expect you will need these, but you don't need them
now.
Andrew
Powered by blists - more mailing lists