linux-kernel - Re: arm scsi drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210827150938.GU22278@shell.armlinux.org.uk>
Date:   Fri, 27 Aug 2021 16:09:39 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     John Garry <john.garry@...wei.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Hannes Reinecke <hare@...e.com>,
        Christoph Hellwig <hch@....de>,
        Bart Van Assche <bvanassche@....org>,
        Arnd Bergmann <arnd@...db.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: arm scsi drivers

I haven't, sorry.

I have run 5.x kernels on the hardware, and do have a set of patches
kicking around for the SCSI drivers that do some cleanups. It looks
like the fixup is pretty simple from the links you've sent - using
scsi_cmd_to_rq() to get the tag.

That said, I think I may only had one SCSI drive that came anywhere
close to supported tagged queuing, so I never put much effort into
tagged command support. Both acornscsi and fas216 have it disabled
for this reason, so it's probably easier just to rip the tag code
out of these drivers.

Russell.

On Fri, Aug 27, 2021 at 03:55:05PM +0100, John Garry wrote:
> Hi Russell,
> 
> Have you had a chance to consider the below?
> 
> Thanks
> 
> 
> > 
> > Recently we tried to remove scsi_cmnd.tags struct member [0].
> > 
> > However it now shows that some of the arm SCSI drivers continue to use
> > this [1]. I think any other driver usage of this member had been found
> > and removed.
> > 
> > The impression is that the usage of scsi_cmnd.tag in those drivers is
> > quite dubious.
> > 
> > Now checking [2], it appears that you may have had some patches for
> > these drivers locally.
> > 
> > So is that the case? Is this HW still used with bleeding edge kernels?
> > If so, can we fix up this tag management?
> > 
> > [0] https://lore.kernel.org/linux-scsi/6c83bd7f-9fd2-1b43-627f-615467fa55d4@huawei.com/T/#mb47909f38f35837686734369600051b278d124af
> > 
> > 
> > [1] https://lore.kernel.org/linux-scsi/6c83bd7f-9fd2-1b43-627f-615467fa55d4@huawei.com/T/#md5d786e5753083b2f3e8e761b1c69809f82c7485
> > 
> > 
> > [2]
> > https://lore.kernel.org/lkml/20210109174357.GB1551@shell.armlinux.org.uk/
> > 
> > Thanks,
> > John
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!