linux-kernel - Re: [PATCH 1/5] staging: rtl8723bs: remove sdio_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YSkSLrmhb4AcKlWu@kroah.com>
Date:   Fri, 27 Aug 2021 18:26:22 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Bryan Brattlof <hello@...anbrattlof.com>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] staging: rtl8723bs: remove sdio_write_mem()

On Fri, Aug 27, 2021 at 04:13:15PM +0000, Bryan Brattlof wrote:
> The sdio_write_mem() function is unused in the driver. We can remove it.
> 
> Signed-off-by: Bryan Brattlof <hello@...anbrattlof.com>
> ---
>  drivers/staging/rtl8723bs/hal/sdio_ops.c   | 11 -----------
>  drivers/staging/rtl8723bs/include/rtw_io.h |  1 -
>  2 files changed, 12 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> index a545832a468e..b784a390c8e1 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> @@ -356,16 +356,6 @@ static void sdio_read_mem(
>  	sdio_readN(intfhdl, addr, cnt, rmem);
>  }
> 
> -static void sdio_write_mem(
> -	struct intf_hdl *intfhdl,
> -	u32 addr,
> -	u32 cnt,
> -	u8 *wmem
> -)
> -{
> -	sdio_writeN(intfhdl, addr, cnt, wmem);
> -}
> -
>  /*
>   * Description:
>   *Read from RX FIFO
> @@ -474,7 +464,6 @@ void sdio_set_intf_ops(struct adapter *adapter, struct _io_ops *ops)
>  	ops->_write16 = &sdio_write16;
>  	ops->_write32 = &sdio_write32;
>  	ops->_writeN = &sdio_writeN;
> -	ops->_write_mem = &sdio_write_mem;
>  	ops->_write_port = &sdio_write_port;
>  }
> 
> diff --git a/drivers/staging/rtl8723bs/include/rtw_io.h b/drivers/staging/rtl8723bs/include/rtw_io.h
> index e98083a07a66..87f36b7e880f 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_io.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_io.h
> @@ -91,7 +91,6 @@ struct _io_ops {
>  		int (*_write32_async)(struct intf_hdl *pintfhdl, u32 addr, u32 val);
> 
>  		void (*_read_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);
> -		void (*_write_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);
> 
>  		void (*_sync_irp_protocol_rw)(struct io_queue *pio_q);
> 
> --
> 2.30.2
> 
> 
> 

THis changed from the previous version in ways you did not document
anywhere.  Please fix up in your v4 notes.