linux-kernel - Re: [PATCH v6 3/3] pwm: Add support for Xilinx AXI Timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c57c4b16-dc8c-76c7-3ac4-63a5b62144d3@seco.com>
Date:   Fri, 27 Aug 2021 12:29:40 -0400
From:   Sean Anderson <sean.anderson@...o.com>
To:     kernel test robot <lkp@...el.com>, linux-pwm@...r.kernel.org,
        devicetree@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Alvaro Gamez <alvaro.gamez@...ent.com>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        linux-arm-kernel@...ts.infradead.org,
        Lee Jones <lee.jones@...aro.org>, michal.simek@...inx.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 3/3] pwm: Add support for Xilinx AXI Timer



On 8/27/21 3:16 AM, kernel test robot wrote:
> Hi Sean,
> 
> I love your patch! Perhaps something to improve:
> 
> [auto build test WARNING on tip/timers/core]
> [also build test WARNING on pwm/for-next linus/master v5.14-rc7 next-20210826]
> [cannot apply to xlnx/master]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Sean-Anderson/dt-bindings-pwm-Add-Xilinx-AXI-Timer/20210827-052011
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 127c92feb74a6721f62587f1b89128808f049cf1
> config: mips-randconfig-r025-20210827 (attached as .config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 1076082a0d97bd5c16a25ee7cf3dbb6ee4b5a9fe)
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # install mips cross compiling tool for clang build
>          # apt-get install binutils-mips-linux-gnu
>          # https://github.com/0day-ci/linux/commit/eab56f0b0c5a62e40c04916eb1b4f21f478cec3a
>          git remote add linux-review https://github.com/0day-ci/linux
>          git fetch --no-tags linux-review Sean-Anderson/dt-bindings-pwm-Add-Xilinx-AXI-Timer/20210827-052011
>          git checkout eab56f0b0c5a62e40c04916eb1b4f21f478cec3a
>          # save the attached .config to linux build tree
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All warnings (new ones prefixed by >>):
> 
>>> drivers/pwm/pwm-xilinx.c:249:34: warning: unused variable 'xilinx_timer_of_match' [-Wunused-const-variable]
>     static const struct of_device_id xilinx_timer_of_match[] = {
>                                      ^
>     1 warning generated.
> 
> 
> vim +/xilinx_timer_of_match +249 drivers/pwm/pwm-xilinx.c
> 
>     248	
>   > 249	static const struct of_device_id xilinx_timer_of_match[] = {
>     250		{ .compatible = "xlnx,xps-timer-1.00.a", },
>     251		{},
>     252	};
>     253	MODULE_DEVICE_TABLE(of, xilinx_timer_of_match);
>     254	

For this and the error on the previous patch it looks like I am missing a dependency on OF_ADDR. Will add.

--Sean