linux-kernel - Re: [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2c141f7e-bec8-49ad-2d2b-d238a372b0e6@linuxfoundation.org>
Date:   Fri, 27 Aug 2021 11:00:43 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     "lizhijian@...itsu.com" <lizhijian@...itsu.com>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
Cc:     "philip.li@...el.com" <philip.li@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC

On 8/26/21 7:35 PM, lizhijian@...itsu.com wrote:
> 
> 
> On 27/08/2021 05:10, Shuah Khan wrote:
>> On 8/25/21 7:58 PM, Li Zhijian wrote:
>>> SYNC was removed since aff9da10e21 ("staging/android: make sync_timeline internal to sw_sync")
>>> LKP/0Day will check if all configs listing under selftests are able to be enabled properly.
>>>
>>
>> Can you please state what you arr fxing and also keep the sentences
>> 75 chars or less.
>>
>> Where is LKP warning?
> https://01.org/lkp
> LKP(aka. 0Day) often reports issue related to the *recent* kernel commits/WIP patches publicly.
> As the LKP keeping improvement, it will cover more aspects in the kernel so that more issues will be detected.
> 
> So in this case, which is related to too old kernel, it just reported it internally.
> 
> 
>> Include the warning and explain why this
>> change is necessary.
> - it's not reasonable to keep the deprecated configs, right ?
> 
> - In my understanding, configs under kselftests are recommended by corresponding tests.
> So if some configs are missing, it will impact the testing results
> 
> Do you mean the commit log should include above 2 reasons ?
> 

Correct. I am asking the commit log to include these details.

thanks,
-- Shuah