linux-kernel - RE: [PATCH v4 0/3] fs/ntfs3: Use kernel alloc wrappers and fix warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <373c644eff6d4e2b8137acc0ca6faf7f@paragon-software.com>
Date:   Fri, 27 Aug 2021 17:12:28 +0000
From:   Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To:     Kari Argillander <kari.argillander@...il.com>,
        "ntfs3@...ts.linux.dev" <ntfs3@...ts.linux.dev>,
        Christoph Hellwig <hch@....de>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Joe Perches <joe@...ches.com>
Subject: RE: [PATCH v4 0/3] fs/ntfs3: Use kernel alloc wrappers and fix
 warnings

> From: Kari Argillander <kari.argillander@...il.com>
> Sent: Tuesday, August 24, 2021 9:37 PM
> To: Konstantin Komarov <almaz.alexandrovich@...agon-software.com>; ntfs3@...ts.linux.dev; Christoph Hellwig <hch@....de>
> Cc: Kari Argillander <kari.argillander@...il.com>; linux-kernel@...r.kernel.org; Joe Perches <joe@...ches.com>
> Subject: [PATCH v4 0/3] fs/ntfs3: Use kernel alloc wrappers and fix warnings
> 
> In ntfs3 driver there is allocation made like this ntfs_malloc().
> Patch 2/3 will converter these to kernel ones like kmalloc(). After I
> did this then checkpatch raise warnings about array allocations so I
> fix these in patch 3/3.
> 
> I also notice when I made patch that there is broken utf8 char so I
> wanted first fix that because it raised some warning in my editor and
> did not want to "break" patch 2/3. And because we are editing comment
> then make whole comment block clean. So patch 1/3 address that. I did
> try to apply this and it seem to work without issues.
> 
> v2:
>  - Add patch 1/3 because I found broken utf8 char in source file
>  - Add another patch 3/3 which will fix allocation warnings
>  - Rewrite some of commit message from first patch
> v3:
>  - Patch series didn't have X/X numbers
>  - Cover letter didn't have fs/ntfs3 in it
>  - One kmalloc was converted to kcalloc insted of kmalloc_array
>  	Thanks Joe Perches
> v4:
>  - Wrap whole comment block in patch 1/1 max 80 char. And restyle.
>  	Thanks Christoph Hellwig for noting this
>  - Add Reviewed-by: from Christoph Hellwig to patch 2 and 3
> 
> Kari Argillander (3):
>   fs/ntfs3: Restyle comment block in ni_parse_reparse()
>   fs/ntfs3: Do not use driver own alloc wrappers
>   fs/ntfs3: Use kcalloc/kmalloc_array over kzalloc/kmalloc
> 
>  fs/ntfs3/attrib.c   |   6 +-
>  fs/ntfs3/attrlist.c |  10 +--
>  fs/ntfs3/bitmap.c   |   8 +--
>  fs/ntfs3/debug.h    |   7 --
>  fs/ntfs3/file.c     |   4 +-
>  fs/ntfs3/frecord.c  |  42 ++++++-----
>  fs/ntfs3/fslog.c    | 172 ++++++++++++++++++++++----------------------
>  fs/ntfs3/fsntfs.c   |   8 +--
>  fs/ntfs3/index.c    |  54 +++++++-------
>  fs/ntfs3/inode.c    |  10 +--
>  fs/ntfs3/lznt.c     |   4 +-
>  fs/ntfs3/ntfs_fs.h  |  18 ++---
>  fs/ntfs3/record.c   |   8 +--
>  fs/ntfs3/run.c      |   8 +--
>  fs/ntfs3/super.c    |  20 +++---
>  fs/ntfs3/xattr.c    |  18 ++---
>  16 files changed, 197 insertions(+), 200 deletions(-)
> 
> --
> 2.25.1

Hi Kari, Christoph and Joe! Thanks for your contribution, applied these patch series to our tree.

Best regards,
Konstantin