linux-kernel - Re: [PATCH] mm/hmm: bypass devmap pte when all pfn requested flags are fulfilled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YSkkx6Tci3n+qN54@infradead.org>
Date:   Fri, 27 Aug 2021 18:45:43 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     Jason Gunthorpe <jgg@...pe.ca>
Cc:     Li Zhijian <lizhijian@...fujitsu.com>, linux-mm@...ck.org,
        linux-rdma@...r.kernel.org, akpm@...ux-foundation.org,
        jglisse@...hat.com, yishaih@...dia.com,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] mm/hmm: bypass devmap pte when all pfn requested flags
 are fulfilled

On Fri, Aug 27, 2021 at 01:28:52PM -0300, Jason Gunthorpe wrote:
> > +	/*
> > +	 * just bypass devmap pte such as DAX page when all pfn requested
> > +	 * flags(pfn_req_flags) are fulfilled.
> > +	 */
> > +	if (pte_devmap(pte))
> > +		goto out;
> 
> I liked your ealier version better where this was added to the
> pte_special test - logically this is about disambiguating the
> pte_special and the devmap case as they are different things.

Yes, I think that is much more logical.  Also please capitalize the
first word in multi-line comments.