linux-kernel - RE: [PATCH v2 3/6] fs/ntfs3: Use new api for mounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9dcbd4fb0dcf434f9241d2ef13763428@paragon-software.com>
Date:   Fri, 27 Aug 2021 18:44:07 +0000
From:   Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To:     Kari Argillander <kari.argillander@...il.com>,
        Christoph Hellwig <hch@....de>
CC:     "ntfs3@...ts.linux.dev" <ntfs3@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        Pali Rohár <pali@...nel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Christian Brauner <christian.brauner@...ntu.com>
Subject: RE: [PATCH v2 3/6] fs/ntfs3: Use new api for mounting

> From: Kari Argillander <kari.argillander@...il.com>
> Sent: Tuesday, August 24, 2021 11:22 AM
> To: Christoph Hellwig <hch@....de>
> Cc: Konstantin Komarov <almaz.alexandrovich@...agon-software.com>; ntfs3@...ts.linux.dev; linux-kernel@...r.kernel.org; linux-
> fsdevel@...r.kernel.org; Pali Rohár <pali@...nel.org>; Matthew Wilcox <willy@...radead.org>; Christian Brauner
> <christian.brauner@...ntu.com>
> Subject: Re: [PATCH v2 3/6] fs/ntfs3: Use new api for mounting
> 
> On Tue, Aug 24, 2021 at 10:03:02AM +0200, Christoph Hellwig wrote:
> > > +	/*
> > > +	 * TODO: We should probably check some mount options does
> > > +	 * they all work after remount. Example can we really change
> > > +	 * nls. Remove this comment when all testing is done or
> > > +	 * even better xfstest is made for it.
> > > +	 */
> >
> > Instead of the TODO I would suggest a prep patch to drop changing of
> > any options in remount before this one and then only add them back
> > as needed and tested.
> 
> This could be good option. I have actually tested nls and it will be
> problem so we definitely drop that. I will wait what Konstantin has
> to say about other.
> 
> > The mechanics of the conversion look good to me.
> 
> I have made quite few changes to make this series better and will
> send v3 in the near future.
> 
> Main change is that we won't allocate sbi when remount. We can
> allocate just options. Also won't let nls/iocharset change.

Hi Kari, looking forward to have v3 series to pick up!

Best regards.