linux-kernel - Re: [PATCH v3] staging: r8188eu: Remove _enter/_exit_critical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 28 Aug 2021 12:18:29 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Martin Kaiser <martin@...ser.cx>,
        Michael Straube <straube.linux@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Pavel Skripkin <paskripkin@...il.com>
Subject: Re: [PATCH v3] staging: r8188eu: Remove _enter/_exit_critical_mutex()

On Friday, August 27, 2021 4:32:22 PM CEST Pavel Skripkin wrote:
> On 8/20/21 1:12 AM, Fabio M. De Francesco wrote:
> > Remove _enter_critical_mutex() and _exit_critical_mutex(). They are
> > unnecessary wrappers, respectively to mutex_lock_interruptible() and
> > to mutex_unlock(). They also have an odd interface that takes an unused
> > argument named pirqL of type unsigned long.
> > The original code enters the critical section if the mutex API is
> > interrupted while waiting to acquire the lock; therefore it could lead
> > to a race condition. Use mutex_lock() because it is uninterruptible and
> > so avoid that above-mentioned potential race condition.
> > 
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@...il.com>
> 
> Tested-by: Pavel Skripkin <paskripkin@...il.com>
> Reviewed-by: Pavel Skripkin <paskripkin@...il.com>
> 
> Thanks!
> 
> 
> With regards,
> Pavel Skripkin
> 
Hi Pavel,

Thanks very much for testing and reviewing my patch. As you know, Greg wanted
it tested but I couldn't do that. I'll add your tags and send a v4 and I guess that now
Greg will easily apply.

Great help from you, thanks again :)

Regards,

Fabio