linux-kernel - Re: [PATCH] staging: r8188eu :os_dep: remove condition with no effect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 28 Aug 2021 18:15:59 +0530
From:   SAURAV GIREPUNJE <saurav.girepunje@...il.com>
To:     Michael Straube <straube.linux@...il.com>
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        gregkh@...uxfoundation.org, nathan@...nel.org,
        linux-kernel@...r.kernel.org, saurav.girepunje@...mail.com
Subject: Re: [PATCH] staging: r8188eu :os_dep: remove condition with no effect

On 28 Aug 2021 12:19, Michael Straube wrote:
> On 8/28/21 11:31, Saurav Girepunje wrote:
> > Remove the condition with no effect (if == else) in usb_intf.c
> > file.
> >
> > Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>
> > ---
> >   drivers/staging/r8188eu/os_dep/usb_intf.c | 6 ++----
> >   1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
> > index bb85ab77fd26..849563b54727 100644
> > --- a/drivers/staging/r8188eu/os_dep/usb_intf.c
> > +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
> > @@ -496,10 +496,8 @@ static int rtw_resume(struct usb_interface *pusb_intf)
> >   	struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
> >   	int ret = 0;
> >
> > -	if (pwrpriv->bInternalAutoSuspend)
> > -		ret = -	else
> > -		ret = rtw_resume_process(padapter);
> > +	ret = rtw_resume_process(padapter);
> > +
> >   	return ret;
> >   }
>
> Thanks for your patch. Perhaps this could be further simplified to:
>
> int ret = rtw_resume_process(padapter);
>
> return ret;
>
> or even:
>
> return rtw_resume_process(padapter);
>
> Best regards,
> Michael


Yes, Thanks Michael. I will make it more simple and send v2.


Regards,
Saurav