linux-kernel - Re: [PATCH] staging: r8188eu: core: remove null check before vfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b098cbe9-1cc6-d97f-e1d8-df6c99b0afa0@gmail.com>
Date:   Sat, 28 Aug 2021 21:30:14 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Saurav Girepunje <saurav.girepunje@...il.com>,
        Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        gregkh@...uxfoundation.org, fabioaiuto83@...il.com,
        ross.schm.dev@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Cc:     saurav.girepunje@...mail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove null check before vfree

On 8/28/21 21:20, Michael Straube wrote:
> On 8/28/21 19:54, Saurav Girepunje wrote:
>> Remove NULL check. NULL check before freeing function is not needed.
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>
>> ---
>>   drivers/staging/r8188eu/core/rtw_sta_mgt.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/r8188eu/core/rtw_sta_mgt.c 
>> b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
>> index f6dffed53a60..4726771a8403 100644
>> --- a/drivers/staging/r8188eu/core/rtw_sta_mgt.c
>> +++ b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
>> @@ -155,9 +155,7 @@ u32    _rtw_free_sta_priv(struct    sta_priv 
>> *pstapriv)
>>           spin_unlock_bh(&pstapriv->sta_hash_lock);
>>           /*===============================*/
>>
>> -        if (pstapriv->pallocated_stainfo_buf)
>> -            vfree(pstapriv->pallocated_stainfo_buf);
>> -        }
>> +        vfree(pstapriv->pallocated_stainfo_buf);
>>
>>       return _SUCCESS;
>>   }
>> -- 
>> 2.32.0
>>
> 
> Acked-by: Michael Straube <straube.linux@...il.com>
> 
> Thanks,
> Michael

Whoops, I missed that you removed the } that belongs to the enclosing if
block. Probably because it is not properly indented in the original
code.

Best regards,
Michael