linux-kernel - Re: [PATCH 3/5] ARM: dts: NSP: Fix MDIO mux node names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YSq1OS+z8KKcUdu5@lunn.ch>
Date:   Sun, 29 Aug 2021 00:14:17 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Matthew Hagan <mnhagan88@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Rob Herring <robh+dt@...nel.org>, Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] ARM: dts: NSP: Fix MDIO mux node names

On Sat, Aug 28, 2021 at 10:52:30PM +0100, Matthew Hagan wrote:
> On 28/08/2021 18:07, Andrew Lunn wrote:
> 
> > On Sat, Aug 28, 2021 at 11:27:01AM +0000, Matthew Hagan wrote:
> >> This patch fixes the following message by adding "mdio-mux" compatible:
> >> compatible: ['mdio-mux-mmioreg'] is too short
> >  
> > Err, what? This sounds like a workaround for a tool problem, not a
> > real fix. 
> >
> > What is actually wrong with:
> >
> > compatible = "mdio-mux-mmioreg";
> 
> Yes this does work fine either with or without "mdio-mux". The changes
> have been made to correspond with those submitted by Rafal Milecki for
> the BCM5301X platform[1] and to conform with
> Documentation/devicetree/bindings/net/mdio-mux-mmioreg.yaml
> which does state both as required items (and hence not a tool problem).

Hi Matthew

It would be good to expand the commit message a bit, since the error
'is too short' is particularly uninformative, and leads to questions
like this if not explained.

It would also good to get the tool improved, but that is out of scope
for this patch.

     Andrew