| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202108281050.q7c4yp9F-lkp@intel.com>
Date: Sat, 28 Aug 2021 10:57:03 +0800
From: kernel test robot <lkp@...el.com>
To: David Howells <dhowells@...hat.com>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [dhowells-fs:fscache-iter-2 73/74] fs/nfs/fscache.c:243:5: warning:
no previous prototype for 'nfs_fscache_release_page'
Hi David,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git fscache-iter-2
head: 28d7bc7b5030ef7829d8e21696522adbf0ae90e4
commit: 0938c7d6a359a6c7a72ce7758d921195be52ec7b [73/74] nfs: Convert to new fscache volume/cookie API
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?id=0938c7d6a359a6c7a72ce7758d921195be52ec7b
git remote add dhowells-fs https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
git fetch --no-tags dhowells-fs fscache-iter-2
git checkout 0938c7d6a359a6c7a72ce7758d921195be52ec7b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> fs/nfs/fscache.c:243:5: warning: no previous prototype for 'nfs_fscache_release_page' [-Wmissing-prototypes]
243 | int nfs_fscache_release_page(struct page *page, gfp_t gfp)
| ^~~~~~~~~~~~~~~~~~~~~~~~
fs/nfs/fscache.c:266:6: warning: no previous prototype for '__nfs_fscache_invalidate_page' [-Wmissing-prototypes]
266 | void __nfs_fscache_invalidate_page(struct page *page, struct inode *inode)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fs/nfs/fscache.c: In function '__nfs_readpage_from_fscache':
fs/nfs/fscache.c:322:15: error: implicit declaration of function 'fscache_read_or_alloc_page' [-Werror=implicit-function-declaration]
322 | ret = fscache_read_or_alloc_page(nfs_i_fscache(inode),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
fs/nfs/fscache.c: In function '__nfs_readpages_from_fscache':
fs/nfs/fscache.c:364:15: error: implicit declaration of function 'fscache_read_or_alloc_pages' [-Werror=implicit-function-declaration]
364 | ret = fscache_read_or_alloc_pages(nfs_i_fscache(inode),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
fs/nfs/fscache.c: In function '__nfs_readpage_to_fscache':
fs/nfs/fscache.c:411:15: error: implicit declaration of function 'fscache_write_page'; did you mean 'fscache_write'? [-Werror=implicit-function-declaration]
411 | ret = fscache_write_page(nfs_i_fscache(inode), page,
| ^~~~~~~~~~~~~~~~~~
| fscache_write
fs/nfs/fscache.c:418:17: error: implicit declaration of function 'fscache_uncache_page'; did you mean 'fscache_update_aux'? [-Werror=implicit-function-declaration]
418 | fscache_uncache_page(nfs_i_fscache(inode), page);
| ^~~~~~~~~~~~~~~~~~~~
| fscache_update_aux
cc1: some warnings being treated as errors
vim +/nfs_fscache_release_page +243 fs/nfs/fscache.c
545db45f0fc0d4 David Howells 2009-04-03 237
545db45f0fc0d4 David Howells 2009-04-03 238 /*
545db45f0fc0d4 David Howells 2009-04-03 239 * Release the caching state associated with a page, if the page isn't busy
545db45f0fc0d4 David Howells 2009-04-03 240 * interacting with the cache.
545db45f0fc0d4 David Howells 2009-04-03 241 * - Returns true (can release page) or false (page busy).
545db45f0fc0d4 David Howells 2009-04-03 242 */
545db45f0fc0d4 David Howells 2009-04-03 @243 int nfs_fscache_release_page(struct page *page, gfp_t gfp)
545db45f0fc0d4 David Howells 2009-04-03 244 {
2c1740098c708b Trond Myklebust 2010-02-08 245 if (PageFsCache(page)) {
f1fe29b4a02d08 David Howells 2013-09-27 246 struct fscache_cookie *cookie = nfs_i_fscache(page->mapping->host);
545db45f0fc0d4 David Howells 2009-04-03 247
545db45f0fc0d4 David Howells 2009-04-03 248 dfprintk(FSCACHE, "NFS: fscache releasepage (0x%p/0x%p/0x%p)\n",
f1fe29b4a02d08 David Howells 2013-09-27 249 cookie, page, NFS_I(page->mapping->host));
545db45f0fc0d4 David Howells 2009-04-03 250
0938c7d6a359a6 David Howells 2021-08-27 251 if (!(gfp & __GFP_DIRECT_RECLAIM) || !(gfp & __GFP_FS))
0938c7d6a359a6 David Howells 2021-08-27 252 return false;
0938c7d6a359a6 David Howells 2021-08-27 253 wait_on_page_fscache(page);
0938c7d6a359a6 David Howells 2021-08-27 254 fscache_note_page_release(cookie);
e9f456ca50e579 Li RongQing 2014-11-23 255 nfs_inc_fscache_stats(page->mapping->host,
e9f456ca50e579 Li RongQing 2014-11-23 256 NFSIOS_FSCACHE_PAGES_UNCACHED);
545db45f0fc0d4 David Howells 2009-04-03 257 }
545db45f0fc0d4 David Howells 2009-04-03 258
0938c7d6a359a6 David Howells 2021-08-27 259 return true;
545db45f0fc0d4 David Howells 2009-04-03 260 }
545db45f0fc0d4 David Howells 2009-04-03 261
:::::: The code at line 243 was first introduced by commit
:::::: 545db45f0fc0d4203b045047798ce156972a3056 NFS: FS-Cache page management
:::::: TO: David Howells <dhowells@...hat.com>
:::::: CC: David Howells <dhowells@...hat.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (60648 bytes)
Powered by blists - more mailing lists