linux-kernel - drivers/net/wireless/intel/iwlwifi/mvm/ftm-responder.c:124 iwl_mvm_ftm_responder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202108281126.sePd1bGl-lkp@intel.com>
Date:   Sat, 28 Aug 2021 11:48:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Avraham Stern <avraham.stern@...el.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Luca Coelho <luciano.coelho@...el.com>
Subject: drivers/net/wireless/intel/iwlwifi/mvm/ftm-responder.c:124
 iwl_mvm_ftm_responder_cmd() warn: inconsistent indenting

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   64b4fc45bea6f4faa843d2f97ff51665280efee1
commit: 20578872d503d5c211bdf334185ccd8afe4ae697 iwlwifi: mvm: responder: support responder config command version 8
date:   5 months ago
config: arc-randconfig-m031-20210827 (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

New smatch warnings:
drivers/net/wireless/intel/iwlwifi/mvm/ftm-responder.c:124 iwl_mvm_ftm_responder_cmd() warn: inconsistent indenting

Old smatch warnings:
arch/arc/include/asm/thread_info.h:65 current_thread_info() error: uninitialized symbol 'sp'.

vim +124 drivers/net/wireless/intel/iwlwifi/mvm/ftm-responder.c

    95	
    96	static int
    97	iwl_mvm_ftm_responder_cmd(struct iwl_mvm *mvm,
    98				  struct ieee80211_vif *vif,
    99				  struct cfg80211_chan_def *chandef)
   100	{
   101		struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
   102		/*
   103		 * The command structure is the same for versions 6, 7 and 8 (only the
   104		 * field interpretation is different), so the same struct can be use
   105		 * for all cases.
   106		 */
   107		struct iwl_tof_responder_config_cmd_v8 cmd = {
   108			.channel_num = chandef->chan->hw_value,
   109			.cmd_valid_fields =
   110				cpu_to_le32(IWL_TOF_RESPONDER_CMD_VALID_CHAN_INFO |
   111					    IWL_TOF_RESPONDER_CMD_VALID_BSSID |
   112					    IWL_TOF_RESPONDER_CMD_VALID_STA_ID),
   113			.sta_id = mvmvif->bcast_sta.sta_id,
   114		};
   115		u8 cmd_ver = iwl_fw_lookup_cmd_ver(mvm->fw, LOCATION_GROUP,
   116						   TOF_RESPONDER_CONFIG_CMD, 6);
   117		int err;
   118	
   119		lockdep_assert_held(&mvm->mutex);
   120	
   121	if (cmd_ver == 8)
   122			iwl_mvm_ftm_responder_set_ndp(mvm, &cmd);
   123	
 > 124		if (cmd_ver >= 7)
   125			err = iwl_mvm_ftm_responder_set_bw_v2(chandef, &cmd.format_bw,
   126							      &cmd.ctrl_ch_position);
   127		else
   128			err = iwl_mvm_ftm_responder_set_bw_v1(chandef, &cmd.format_bw,
   129							      &cmd.ctrl_ch_position);
   130	
   131		if (err) {
   132			IWL_ERR(mvm, "Failed to set responder bandwidth\n");
   133			return err;
   134		}
   135	
   136		memcpy(cmd.bssid, vif->addr, ETH_ALEN);
   137	
   138		return iwl_mvm_send_cmd_pdu(mvm, iwl_cmd_id(TOF_RESPONDER_CONFIG_CMD,
   139							    LOCATION_GROUP, 0),
   140					    0, sizeof(cmd), &cmd);
   141	}
   142	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (36656 bytes)