linux-kernel - Re: [PATCH] staging: wlan-ng: fix invalid assignment warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202108272257.7396C4D146@keescook>
Date:   Fri, 27 Aug 2021 22:58:30 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Aakash Hemadri <aakashhemadri123@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: fix invalid assignment warning

On Sat, Aug 28, 2021 at 09:59:49AM +0530, Aakash Hemadri wrote:
> p80211_hdr->frame_control is u16, change to __le16
> to satisfy sparse warning:
> 
> wlan-ng/prism2sta.c:253:43: warning: invalid assignment: |=
> wlan-ng/prism2sta.c:253:43:    left side has type unsigned short
> wlan-ng/prism2sta.c:253:43:    right side has type restricted __le16
> 
> Signed-off-by: Aakash Hemadri <aakashhemadri123@...il.com>

Whoops; thanks for catching that.

Fixes: 6277fbfdd29c ("staging: wlan-ng: Remove pointless a3/a4 union")
Reviewed-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  drivers/staging/wlan-ng/p80211hdr.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wlan-ng/p80211hdr.h b/drivers/staging/wlan-ng/p80211hdr.h
> index dd1fb99bf340..5871a55e4a61 100644
> --- a/drivers/staging/wlan-ng/p80211hdr.h
> +++ b/drivers/staging/wlan-ng/p80211hdr.h
> @@ -149,7 +149,7 @@
>  /* Generic 802.11 Header types */
>  
>  struct p80211_hdr {
> -	u16	frame_control;
> +	__le16	frame_control;
>  	u16	duration_id;
>  	u8	address1[ETH_ALEN];
>  	u8	address2[ETH_ALEN];
> 
> base-commit: f6bc526accf861728d36b12fbc25ac94cd057fc9
> -- 
> 2.32.0
> 

-- 
Kees Cook