linux-kernel - Re: [PATCH v3 2/2] iio: accel: Add driver support for ADXL313

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vcmg91+cC6st41yTezhV_xQgDkSCprGirEARhETJT=LOQ@mail.gmail.com>
Date:   Sun, 29 Aug 2021 17:19:19 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Lucas Stankus <lucas.p.stankus@...il.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "Bogdan, Dragos" <Dragos.Bogdan@...log.com>,
        Darius <Darius.Berghe@...log.com>,
        linux-iio <linux-iio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] iio: accel: Add driver support for ADXL313

On Wed, Aug 18, 2021 at 11:02 PM Lucas Stankus
<lucas.p.stankus@...il.com> wrote:
> On Thu, Aug 12, 2021 at 8:06 AM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> > On Thu, Aug 12, 2021 at 12:19 AM Lucas Stankus
> > <lucas.p.stankus@...il.com> wrote:

...

> > > +       return regmap_update_bits(data->regmap, ADXL313_REG_BW_RATE,
> > > +                                 ADXL313_RATE_MSK,
> >
> > > +                                 FIELD_PREP(ADXL313_RATE_MSK,
> > > +                                            ADXL313_RATE_BASE + i));
> >
> > One line?
> >
>
> Line to long, 87 chars =/

I think it's fine in this case. It will keep the entire FIELD_PREP()
on one line.

-- 
With Best Regards,
Andy Shevchenko