linux-kernel - Re: [PATCH 0/3] staging: r8188eu: cleanup c2h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f63d7e1-0eb4-21c0-49eb-262cdadf0e87@gmail.com>
Date:   Sun, 29 Aug 2021 17:04:02 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Phillip Potter <phil@...lpotter.co.uk>, gregkh@...uxfoundation.org
Cc:     fmdefrancesco@...il.com, Larry.Finger@...inger.net,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] staging: r8188eu: cleanup c2h_handler code

On 8/28/21 23:24, Phillip Potter wrote:
> This small patch set cleans up the c2h_handler code in the HAL layer
> of the driver. In r8188eu, this field of struct hal_ops, is not even
> used, so dependent code has always returned _FAIL. For this reason, we
> should remove this function pointer field, and the wrapper function
> which checks it. This is done in stages by this set, and helps get
> the driver closer to the pointer where the HAL layer is
> deleted/integrated as necessary and no longer a separate entity.
> 
> Phillip Potter (3):
>    staging: r8188eu: remove c2h_handler field from struct hal_ops
>    staging: r8188eu: simplify c2h_evt_hdl function
>    staging: r8188eu: remove rtw_hal_c2h_handler function
> 
>   drivers/staging/r8188eu/core/rtw_cmd.c     | 23 +++-------------------
>   drivers/staging/r8188eu/hal/hal_intf.c     |  9 ---------
>   drivers/staging/r8188eu/include/hal_intf.h |  4 ----
>   3 files changed, 3 insertions(+), 33 deletions(-)
> 

Thanks for your patches Phillip. Looks good to me and I've built and
runtime tested this series with Inter-Tech DMG-02, so...

Acked-by: Michael Straube <straube.linux@...il.com>

Thanks,
Michael