linux-kernel - Re: [PATCH 0/3] staging: r8188eu: cleanup c2h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 29 Aug 2021 23:59:48 +0100
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Michael Straube <straube.linux@...il.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        "open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] staging: r8188eu: cleanup c2h_handler code

On Sun, 29 Aug 2021 at 13:48, Fabio M. De Francesco
<fmdefrancesco@...il.com> wrote:
>
> On Saturday, August 28, 2021 11:24:50 PM CEST Phillip Potter wrote:
> > This small patch set cleans up the c2h_handler code in the HAL layer
> > of the driver. In r8188eu, this field of struct hal_ops, is not even
> > used, so dependent code has always returned _FAIL. For this reason, we
> > should remove this function pointer field, and the wrapper function
> > which checks it. This is done in stages by this set, and helps get
> > the driver closer to the pointer where the HAL layer is
> > deleted/integrated as necessary and no longer a separate entity.
> >
> > Phillip Potter (3):
> >   staging: r8188eu: remove c2h_handler field from struct hal_ops
> >   staging: r8188eu: simplify c2h_evt_hdl function
> >   staging: r8188eu: remove rtw_hal_c2h_handler function
> >
> >  drivers/staging/r8188eu/core/rtw_cmd.c     | 23 +++-------------------
> >  drivers/staging/r8188eu/hal/hal_intf.c     |  9 ---------
> >  drivers/staging/r8188eu/include/hal_intf.h |  4 ----
> >  3 files changed, 3 insertions(+), 33 deletions(-)
> >
> > --
> > 2.31.1
> >
> Dear Philip,
>
> You work looks good (especially after having clarified a couple of minor doubts
> I had expressed in another message). So, the entire series is...
>
> Acked-by: Fabio M. De Francesco <fmdefrancesco@...il.com>
>
> Regards,
>
> Fabio
>

Dear Fabio,

Thanks very much for the review and Acked-by, much appreciated.

Regards,
Phil