linux-kernel - Re: [PATCH v1 0/4] char: xillybus: Remove usage of the deprecated 'pci-dma-compat.h' API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 29 Aug 2021 11:23:06 +0300
From:   Eli Billauer <eli.billauer@...il.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
CC:     gregkh <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH v1 0/4] char: xillybus: Remove usage of the deprecated
 'pci-dma-compat.h' API

On 29/08/21 00:26, Arnd Bergmann wrote:
>
> The documentation was updated 11 years ago to only describe the modern
> linux/dma-mapping.h interfaces and mark the old bus-specific ones as
> no longer recommended, see 216bf58f4092 ("Documentation: convert
> PCI-DMA-mapping.txt to use the generic DMA API").
>    
Thanks, Arnd. That's exactly the kind of reference I was asking about.

And of course, a thanks goes to Christophe as well for drawing my 
attention to this issue. A bit surprising it didn't happen back in 2013, 
when the driver was included in the kernel. Or possibly in 2014, when it 
went out of staging.

As for this patch set, three out of four patches make modifications in 
functions that should be deleted altogether. Their only purpose is to 
wrap DMA-related calls made by the core driver, so that the pci_* API is 
used for PCI devices, and the dma_* API otherwise. As it turns out, this 
was a lot of nonsense code from day one.

I'll prepare a patch that removes all this.

Thanks again,
    Eli