linux-kernel - Re: [PATCH v2] perf bpf: Fix memory leaks relating to BTF.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YS1NtCLgQzB7GILt@kernel.org>
Date:   Mon, 30 Aug 2021 18:29:24 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     kajoljain <kjain@...ux.ibm.com>
Cc:     Ian Rogers <irogers@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        eranian@...gle.com
Subject: Re: [PATCH v2] perf bpf: Fix memory leaks relating to BTF.

Em Fri, Aug 27, 2021 at 12:58:09PM +0530, kajoljain escreveu:
> Patch looks good me.
> 
> Reviewed-by: Kajol Jain<kjain@...ux.ibm.com>

Thanks, applied.

- Arnaldo

 
> Thanks,
> Kajol Jain
> 
> On 8/27/21 12:18 AM, Ian Rogers wrote:
> > BTF needs to be freed with btf__free.
> > 
> > Signed-off-by: Ian Rogers <irogers@...gle.com>
> > ---
> >  tools/perf/util/annotate.c  | 2 +-
> >  tools/perf/util/bpf-event.c | 4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> > index d43f6b5e5169..0bae061b2d6d 100644
> > --- a/tools/perf/util/annotate.c
> > +++ b/tools/perf/util/annotate.c
> > @@ -1833,7 +1833,7 @@ static int symbol__disassemble_bpf(struct symbol *sym,
> >  	ret = 0;
> >  out:
> >  	free(prog_linfo);
> > -	free(btf);
> > +	btf__free(btf);
> >  	fclose(s);
> >  	bfd_close(bfdf);
> >  	return ret;
> > diff --git a/tools/perf/util/bpf-event.c b/tools/perf/util/bpf-event.c
> > index cdecda1ddd36..17a9844e4fbf 100644
> > --- a/tools/perf/util/bpf-event.c
> > +++ b/tools/perf/util/bpf-event.c
> > @@ -296,7 +296,7 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_session *session,
> >  
> >  out:
> >  	free(info_linear);
> > -	free(btf);
> > +	btf__free(btf);
> >  	return err ? -1 : 0;
> >  }
> >  
> > @@ -486,7 +486,7 @@ static void perf_env__add_bpf_info(struct perf_env *env, u32 id)
> >  	perf_env__fetch_btf(env, btf_id, btf);
> >  
> >  out:
> > -	free(btf);
> > +	btf__free(btf);
> >  	close(fd);
> >  }
> >  
> > 

-- 

- Arnaldo