linux-kernel - Re: [PATCH v3 0/1] libata: Add ATA_HORKAGE_NONCQ_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Aug 2021 21:45:48 +0000
From:   Damien Le Moal <Damien.LeMoal@....com>
To:     Kate Hsuan <hpa@...hat.com>, Jens Axboe <axboe@...nel.dk>,
        Hans de Goede <hdegoede@...hat.com>
CC:     "linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 0/1] libata: Add ATA_HORKAGE_NONCQ_ON_AMD for Samsung
 860 and 870 SSD.

On 2021/08/30 23:43, Kate Hsuan wrote:
> Many users reported the issue when running the system with Samsung 860,
> 870 SSD, and AMD chipset. Therefore, completely disabling the NCQ can
> avoid this issue.
> 
> Entire disabling NCQ for Samsung 860/870 SSD will cause I/O performance
> drop. In this case, a flag ATA_HORKAGE_NONCQ_ON_AMD is introduced to
> used to perform an additional check for these SSDs. If it finds its parent
> ATA controller is AMD, the NCQ will be disabled. Otherwise, the NCQ is kept
> to enable.

For a single patch, generally, a cover letter is not needed. Especially so in
this case since your cover letter message is the same as the patch commit message.

> 
> Changes since v3
> * Modified the flag from ATA_HORKAGE_NONCQ_ON_ASMEDIA_AMD_MARVELL to
>   ATA_HORKAGE_NONCQ_ON_AMD.
> * Modified and fixed the code to completely disable NCQ on AMD controller.

Technically, this is a v2 right ? Also, by "completely", did you mean "always" ?
(see patch comments).

> 
> 
> Kate Hsuan (1):
>   libata: Add ATA_HORKAGE_NONCQ_ON_AMD for Samsung 860 and 870 SSD.
> 
>  drivers/ata/libata-core.c | 24 ++++++++++++++++++++++--
>  include/linux/libata.h    |  1 +
>  2 files changed, 23 insertions(+), 2 deletions(-)
> 


-- 
Damien Le Moal
Western Digital Research