linux-kernel - Re: [PATCH] arm: dts: qcom-msm8974: Add xo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YS1YhsT2iIj3Ydd9@Marijn-Arch-PC.localdomain>
Date:   Tue, 31 Aug 2021 00:15:34 +0200
From:   Marijn Suijten <marijn.suijten@...ainline.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Martin Botka <martin.botka@...ainline.org>,
        Jami Kettunen <jami.kettunen@...ainline.org>,
        Pavel Dubrova <pashadubrova@...il.com>,
        Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Brian Masney <masneyb@...tation.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm: dts: qcom-msm8974: Add xo_board reference clock to
 DSI0 PHY

On 2021-08-30 16:28:15, Bjorn Andersson wrote:
> On Mon 30 Aug 12:57 CDT 2021, Marijn Suijten wrote:
> 
> > According to YAML validation, and for a future patchset putting this
> > xo_board reference clock to use as VCO reference parent, add the missing
> > clock to dsi_phy0.
> > 
> 
> And just to confirm on MSM8974 "ref" is supposed to be 19.2Mhz?

Yes, the 28nm-hpm driver (unlike the 28nm-8960 driver for apq8064) uses
19.2MHz for its hardcoded VCO_REF_CLK_RATE calculations.

Perhaps we should reword the commit message to read "... add the missing
19.2MHz xo clock ...".

- Marijn

> Regards,
> Bjorn
> 
> > Fixes: 5a9fc531f6ec ("ARM: dts: msm8974: add display support")
> > Signed-off-by: Marijn Suijten <marijn.suijten@...ainline.org>
> > ---
> >  arch/arm/boot/dts/qcom-msm8974.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> > index db4c06bf7888..96722172b064 100644
> > --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> > +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> > @@ -1580,8 +1580,8 @@ dsi_phy0: dsi-phy@...22a00 {
> >  				#phy-cells = <0>;
> >  				qcom,dsi-phy-index = <0>;
> >  
> > -				clocks = <&mmcc MDSS_AHB_CLK>;
> > -				clock-names = "iface";
> > +				clocks = <&mmcc MDSS_AHB_CLK>, <&xo_board>;
> > +				clock-names = "iface", "ref";
> >  			};
> >  		};
> >  
> > -- 
> > 2.33.0
> >