linux-kernel - Re: [PATCH v1 3/3] pvpanic: Indentation fixes here and there

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6edf9acc-1385-f6b0-cf36-8d52e2bcf7b8@oracle.com>
Date:   Mon, 30 Aug 2021 09:29:50 +0300
From:   Mihai Carabas <mihai.carabas@...cle.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v1 3/3] pvpanic: Indentation fixes here and there

La 29.08.2021 15:43, Andy Shevchenko a scris:
> 1) replace double spaces with single;
> 2) relax line width limitation a bit.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Reviewed-by: Mihai Carabas <mihai.carabas@...cle.com>
> ---
>   drivers/misc/pvpanic/pvpanic-mmio.c |  7 +++----
>   drivers/misc/pvpanic/pvpanic-pci.c  | 12 +++++-------
>   drivers/misc/pvpanic/pvpanic.c      | 11 ++++-------
>   3 files changed, 12 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/misc/pvpanic/pvpanic-mmio.c b/drivers/misc/pvpanic/pvpanic-mmio.c
> index 61dbff5f0065..eb97167c03fb 100644
> --- a/drivers/misc/pvpanic/pvpanic-mmio.c
> +++ b/drivers/misc/pvpanic/pvpanic-mmio.c
> @@ -24,8 +24,7 @@ MODULE_AUTHOR("Hu Tao <hutao@...fujitsu.com>");
>   MODULE_DESCRIPTION("pvpanic-mmio device driver");
>   MODULE_LICENSE("GPL");
>   
> -static ssize_t capability_show(struct device *dev,
> -			       struct device_attribute *attr, char *buf)
> +static ssize_t capability_show(struct device *dev, struct device_attribute *attr, char *buf)
>   {
>   	struct pvpanic_instance *pi = dev_get_drvdata(dev);
>   
> @@ -33,14 +32,14 @@ static ssize_t capability_show(struct device *dev,
>   }
>   static DEVICE_ATTR_RO(capability);
>   
> -static ssize_t events_show(struct device *dev,  struct device_attribute *attr, char *buf)
> +static ssize_t events_show(struct device *dev, struct device_attribute *attr, char *buf)
>   {
>   	struct pvpanic_instance *pi = dev_get_drvdata(dev);
>   
>   	return sysfs_emit(buf, "%x\n", pi->events);
>   }
>   
> -static ssize_t events_store(struct device *dev,  struct device_attribute *attr,
> +static ssize_t events_store(struct device *dev, struct device_attribute *attr,
>   			    const char *buf, size_t count)
>   {
>   	struct pvpanic_instance *pi = dev_get_drvdata(dev);
> diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c
> index 7d1220f4c95b..07eddb5ea30f 100644
> --- a/drivers/misc/pvpanic/pvpanic-pci.c
> +++ b/drivers/misc/pvpanic/pvpanic-pci.c
> @@ -19,11 +19,10 @@
>   #define PCI_DEVICE_ID_REDHAT_PVPANIC     0x0011
>   
>   MODULE_AUTHOR("Mihai Carabas <mihai.carabas@...cle.com>");
> -MODULE_DESCRIPTION("pvpanic device driver ");
> +MODULE_DESCRIPTION("pvpanic device driver");
>   MODULE_LICENSE("GPL");
>   
> -static ssize_t capability_show(struct device *dev,
> -			       struct device_attribute *attr, char *buf)
> +static ssize_t capability_show(struct device *dev, struct device_attribute *attr, char *buf)
>   {
>   	struct pvpanic_instance *pi = dev_get_drvdata(dev);
>   
> @@ -31,14 +30,14 @@ static ssize_t capability_show(struct device *dev,
>   }
>   static DEVICE_ATTR_RO(capability);
>   
> -static ssize_t events_show(struct device *dev,  struct device_attribute *attr, char *buf)
> +static ssize_t events_show(struct device *dev, struct device_attribute *attr, char *buf)
>   {
>   	struct pvpanic_instance *pi = dev_get_drvdata(dev);
>   
>   	return sysfs_emit(buf, "%x\n", pi->events);
>   }
>   
> -static ssize_t events_store(struct device *dev,  struct device_attribute *attr,
> +static ssize_t events_store(struct device *dev, struct device_attribute *attr,
>   			    const char *buf, size_t count)
>   {
>   	struct pvpanic_instance *pi = dev_get_drvdata(dev);
> @@ -65,8 +64,7 @@ static struct attribute *pvpanic_pci_dev_attrs[] = {
>   };
>   ATTRIBUTE_GROUPS(pvpanic_pci_dev);
>   
> -static int pvpanic_pci_probe(struct pci_dev *pdev,
> -			     const struct pci_device_id *ent)
> +static int pvpanic_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   {
>   	struct pvpanic_instance *pi;
>   	void __iomem *base;
> diff --git a/drivers/misc/pvpanic/pvpanic.c b/drivers/misc/pvpanic/pvpanic.c
> index 254d35efb0b7..c9b5a66697ea 100644
> --- a/drivers/misc/pvpanic/pvpanic.c
> +++ b/drivers/misc/pvpanic/pvpanic.c
> @@ -23,7 +23,7 @@
>   #include "pvpanic.h"
>   
>   MODULE_AUTHOR("Mihai Carabas <mihai.carabas@...cle.com>");
> -MODULE_DESCRIPTION("pvpanic device driver ");
> +MODULE_DESCRIPTION("pvpanic device driver");
>   MODULE_LICENSE("GPL");
>   
>   static struct list_head pvpanic_list;
> @@ -43,8 +43,7 @@ pvpanic_send_event(unsigned int event)
>   }
>   
>   static int
> -pvpanic_panic_notify(struct notifier_block *nb, unsigned long code,
> -		     void *unused)
> +pvpanic_panic_notify(struct notifier_block *nb, unsigned long code, void *unused)
>   {
>   	unsigned int event = PVPANIC_PANICKED;
>   
> @@ -94,8 +93,7 @@ static int pvpanic_init(void)
>   	INIT_LIST_HEAD(&pvpanic_list);
>   	spin_lock_init(&pvpanic_lock);
>   
> -	atomic_notifier_chain_register(&panic_notifier_list,
> -				       &pvpanic_panic_nb);
> +	atomic_notifier_chain_register(&panic_notifier_list, &pvpanic_panic_nb);
>   
>   	return 0;
>   }
> @@ -103,8 +101,7 @@ module_init(pvpanic_init);
>   
>   static void pvpanic_exit(void)
>   {
> -	atomic_notifier_chain_unregister(&panic_notifier_list,
> -					 &pvpanic_panic_nb);
> +	atomic_notifier_chain_unregister(&panic_notifier_list, &pvpanic_panic_nb);
>   
>   }
>   module_exit(pvpanic_exit);