linux-kernel - Re: [PATCH v2] mm/hmm: bypass devmap pte when all pfn requested flags are fulfilled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YSyJdUirSGv01nTy@infradead.org>
Date:   Mon, 30 Aug 2021 08:32:05 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     Li Zhijian <lizhijian@...fujitsu.com>
Cc:     linux-mm@...ck.org, linux-rdma@...r.kernel.org,
        akpm@...ux-foundation.org, jglisse@...hat.com, jgg@...pe.ca,
        hch@...radead.org, yishaih@...dia.com,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] mm/hmm: bypass devmap pte when all pfn requested
 flags are fulfilled

On Sat, Aug 28, 2021 at 09:04:41AM +0800, Li Zhijian wrote:
> +	if (!pte_devmap(pte) && pte_special(pte) &&
> +	    !is_zero_pfn(pte_pfn(pte))) {

Maybe this is a little too superficial and nitpicky, but I find the
ordering of the checks a little strange.  Why not do the pte_special
first and then the exlusions from it later?